From: Heiko Stuebner <heiko@sntech.de>
To: Frank Wang <frank.wang@rock-chips.com>
Cc: srinivas.kandagatla@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, huangtao@rock-chips.com,
finley.xiao@rock-chips.com, cl@rock-chips.com,
wmc@rock-chips.com
Subject: Re: [PATCH] nvmem: rockchip-efuse: amend compatible rk322x-efuse to rk3228-efuse
Date: Thu, 22 Jun 2017 11:10:46 +0200 [thread overview]
Message-ID: <48352151.OspxPMcbie@phil> (raw)
In-Reply-To: <1498121207-24941-1-git-send-email-frank.wang@rock-chips.com>
Am Donnerstag, 22. Juni 2017, 16:46:47 CEST schrieb Frank Wang:
> As the comments from Heiko Stuebner <heiko@sntech.de> that compatible
> should not contain any placeholders, this patch fix it for rk3228 SoC.
>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
not sure how this slipped through in the first place, but the rk322x
compatible would only make it into 4.13, so it should still be fine to
simply correct that issue, before it hits mainline.
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 2 +-
> drivers/nvmem/rockchip-efuse.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> index 194926f..1ff02afd 100644
> --- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> +++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> @@ -4,7 +4,7 @@ Required properties:
> - compatible: Should be one of the following.
> - "rockchip,rk3066a-efuse" - for RK3066a SoCs.
> - "rockchip,rk3188-efuse" - for RK3188 SoCs.
> - - "rockchip,rk322x-efuse" - for RK322x SoCs.
> + - "rockchip,rk3228-efuse" - for RK3228 SoCs.
> - "rockchip,rk3288-efuse" - for RK3288 SoCs.
> - "rockchip,rk3399-efuse" - for RK3399 SoCs.
> - reg: Should contain the registers location and exact eFuse size
> diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c
> index a0d4ede..63e3eb5 100644
> --- a/drivers/nvmem/rockchip-efuse.c
> +++ b/drivers/nvmem/rockchip-efuse.c
> @@ -170,7 +170,7 @@ static const struct of_device_id rockchip_efuse_match[] = {
> .data = (void *)&rockchip_rk3288_efuse_read,
> },
> {
> - .compatible = "rockchip,rk322x-efuse",
> + .compatible = "rockchip,rk3228-efuse",
> .data = (void *)&rockchip_rk3288_efuse_read,
> },
> {
>
next prev parent reply other threads:[~2017-06-22 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 8:46 [PATCH] nvmem: rockchip-efuse: amend compatible rk322x-efuse to rk3228-efuse Frank Wang
2017-06-22 9:10 ` Heiko Stuebner [this message]
2017-06-26 18:39 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48352151.OspxPMcbie@phil \
--to=heiko@sntech.de \
--cc=cl@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=finley.xiao@rock-chips.com \
--cc=frank.wang@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=wmc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).