From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759353AbYGPDZu (ORCPT ); Tue, 15 Jul 2008 23:25:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754550AbYGPDZh (ORCPT ); Tue, 15 Jul 2008 23:25:37 -0400 Received: from ti-out-0910.google.com ([209.85.142.187]:63900 "EHLO ti-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752984AbYGPDZg (ORCPT ); Tue, 15 Jul 2008 23:25:36 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=sd54SWFK2goKukwjxErVG3dQ4dMve/a4jIw6dAZlZmTfFckdLFzPfYw9nv1ZCZa5G5 wCyjQvE8hb7iBYrKqRwGzr9xtDo4q+uVCtc+USdAaFkOi0i86wZ/5USM9qbH7xFaWv8L WlIc04v6Ajnd/w4LFkT7SSSqyWJgjrcnxOsTE= Message-ID: <487D6A24.9070001@gmail.com> Date: Wed, 16 Jul 2008 12:25:24 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.12 (X11/20071114) MIME-Version: 1.0 To: "Eric W. Biederman" CC: Greg KH , Andrew Morton , Daniel Lezcano , linux-kernel@vger.kernel.org, Al Viro , Linux Containers , Benjamin Thery , netdev@vger.kernel.org Subject: Re: [PATCH 12/15] driver core: Implement tagged directory support for device classes. References: <486DD650.3000804@gmail.com> <486E2C3B.6020603@gmail.com> <20080704161200.GA1440@suse.de> In-Reply-To: X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric W. Biederman wrote: > Greg KH writes: >> Sorry, Greg is walking out the door in 30 minutes for a much needed week >> long vacation and can't look into this right now :( >> >> I'll be able to review it next weekend, sorry for the delay. > > Any progress in reviewing these changes, and seeing if you can stand > to merge them? Greg, please disregard my earlier NACKs and commit the patches if you're okay with them. I'm working on cleaning it up but I don't think I'll be able to make it in time for merge window and as Eric said getting the functionality in place is more important at this point as it doesn't affect user visible interface. Eric, with the multiple superblocks, sysfs now uses inode from the default sysfs_sb with dentries from other sb's. Is this okay? Are there any other filesystems which do this? Thanks. -- tejun