From: Valentin Schneider <firstname.lastname@example.org> To: Ionela Voinescu <email@example.com> Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, Jonathan Corbet <firstname.lastname@example.org> Subject: Re: [PATCH v2 4/6] Documentation: arm64: document support for the AMU extension Date: Tue, 28 Jan 2020 18:36:23 +0000 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20200128165325.GA16417@arm.com> On 28/01/2020 16:53, Ionela Voinescu wrote: > Or you won't be able to access them at all. Lacking firmware support > accesses to AMU registers could be trapped in EL3. If access for EL1 and > EL2 is enabled from EL3, it's still possible that the counters > themselves are not enabled - that means they are not enabled to count > the events they are designed to be counting. That's why in this case the > event counter register could read 0. > > But if we read 0, it does not necessarily mean that the counter is > disabled. It could also mean that the events is meant to count did not > happen yet. > Right, which (as we discussed offline) is quite likely to happen if/when we get stuff like SVE counters and we try to read them at boot time. Might be worth adding a small note about that (0 != disabled). >> I haven't seen something that would try to catch this on the kernel side. >> Can we try to detect that (e.g. at least one counter returns > 0) in >> cpu_amu_enable() and thus not write to the CPU-local 'amu_feat'? >> > > I'm reluctant to do this especially given that platforms might choose to > keep some counters disabled while enabling some counters that might not > have counted any events by the time we reach cpu_enable. We would end up > mistakenly disabling the feature. I would rather leave the validation of > the counters to be done at the location and for the purpose of their > use: see patch 6/6 - the use of counters for frequency invariance. > Hmph, I'm a bit torn on that one. It would be really nice to provide *some* amount of sanity checking at core level - e.g. by checking that at least one of the four architected counters reads non-zero. But as you say these could be disabled, while some other arch/aux counter is enabled, and we could then mistakenly disable the feature. So we can't really do much unless we handle *each* individual counter. Oh well :/ >> While we're on the topic of detecting broken stuff, what if some CPUs >> implement some auxiliary counters that some others don't? >> > > I think it should be up to the user of that counter to decide if the > usecase is at CPU level or system level. My intention of this base > support was to keep it simple and allow users of some counters to > decide on their own how to validate and make use of either architected > or auxiliary counters. > > For example, in the case of frequency invariance, given a platform that > does not support cpufreq based invariance, I would validate all CPUs for > the use of AMU core and constant counters. If it happens that some CPUs > do not support those counters or they are not enabled, we'd have to > disable frequency invariance at system level. > > For some other scenarios only partial support is needed - only a subset > of CPUs need to support the counters for their use to be feasible. > > But I believe only the user of the counters can decide, whether this is > happening in architecture code, driver code, generic code. > Right, the FIE support is actually a good example of that, I think.
next prev parent reply other threads:[~2020-01-28 18:36 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-18 18:26 [PATCH v2 0/6] arm64: ARMv8.4 Activity Monitors support Ionela Voinescu 2019-12-18 18:26 ` [PATCH v2 1/6] arm64: add support for the AMU extension v1 Ionela Voinescu 2020-01-23 17:04 ` Valentin Schneider 2020-01-23 18:32 ` Ionela Voinescu 2020-01-24 12:00 ` Valentin Schneider 2020-01-28 11:00 ` Ionela Voinescu 2020-01-28 16:34 ` Suzuki Kuruppassery Poulose 2020-01-29 16:42 ` Ionela Voinescu 2019-12-18 18:26 ` [PATCH v2 2/6] arm64: trap to EL1 accesses to AMU counters from EL0 Ionela Voinescu 2020-01-23 17:04 ` Valentin Schneider 2020-01-23 17:34 ` Ionela Voinescu 2019-12-18 18:26 ` [PATCH v2 3/6] arm64/kvm: disable access to AMU registers from kvm guests Ionela Voinescu 2020-01-27 15:33 ` Valentin Schneider 2020-01-28 15:48 ` Ionela Voinescu 2020-01-28 17:26 ` Suzuki Kuruppassery Poulose 2020-01-28 17:37 ` Valentin Schneider 2020-01-28 17:52 ` Ionela Voinescu 2019-12-18 18:26 ` [PATCH v2 4/6] Documentation: arm64: document support for the AMU extension Ionela Voinescu 2020-01-27 16:47 ` Valentin Schneider 2020-01-28 16:53 ` Ionela Voinescu 2020-01-28 18:36 ` Valentin Schneider [this message] 2020-01-30 15:04 ` Suzuki Kuruppassery Poulose 2020-01-30 16:45 ` Ionela Voinescu 2020-01-30 18:26 ` Suzuki K Poulose 2020-01-31 9:54 ` Ionela Voinescu 2019-12-18 18:26 ` [PATCH v2 5/6] TEMP: sched: add interface for counter-based frequency invariance Ionela Voinescu 2020-01-29 19:37 ` Peter Zijlstra 2020-01-30 15:33 ` Ionela Voinescu 2019-12-18 18:26 ` [PATCH v2 6/6] arm64: use activity monitors for " Ionela Voinescu 2020-01-23 11:49 ` Lukasz Luba 2020-01-23 17:07 ` Ionela Voinescu 2020-01-24 1:19 ` Lukasz Luba 2020-01-24 13:12 ` Ionela Voinescu 2020-01-24 15:17 ` Lukasz Luba 2020-01-28 17:36 ` Ionela Voinescu 2020-01-29 17:13 ` Valentin Schneider 2020-01-29 17:52 ` Ionela Voinescu 2020-01-29 23:39 ` Valentin Schneider 2020-01-30 15:49 ` Ionela Voinescu 2020-01-30 16:11 ` Valentin Schneider
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v2 4/6] Documentation: arm64: document support for the AMU extension' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).