From: Aswath Govindraju <a-govindraju@ti.com>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Sekhar Nori <nsekhar@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Pratyush Yadav <p.yadav@ti.com>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vadym Kochan <vadym.kochan@plvision.eu>,
Andrew Morton <akpm@linux-foundation.org>,
Anatolij Gustschin <agust@denx.de>,
Randy Dunlap <rdunlap@infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] misc: eeprom_93xx46: Fix module alias to enable module autoprobe
Date: Wed, 13 Jan 2021 10:45:54 +0530 [thread overview]
Message-ID: <487d20da-88d0-4d7b-8a39-b5a52f5cd63e@ti.com> (raw)
In-Reply-To: <5c719840-7fa2-6b90-21a8-351f8460d938@ti.com>
On 12/01/21 12:49 pm, Vignesh Raghavendra wrote:
>
>
> On 1/7/21 10:09 PM, Aswath Govindraju wrote:
>> Fix module autoprobe by correcting module alias to match the string from
>> /sys/class/.../spi1.0/modalias content.
>>
>> Fixes: 06b4501e88ad ("misc/eeprom: add driver for microwire 93xx46 EEPROMs")
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> ---
>> drivers/misc/eeprom/eeprom_93xx46.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c
>> index a18247696ce7..890624d97774 100644
>> --- a/drivers/misc/eeprom/eeprom_93xx46.c
>> +++ b/drivers/misc/eeprom/eeprom_93xx46.c
>> @@ -526,4 +526,4 @@ module_spi_driver(eeprom_93xx46_driver);
>> MODULE_LICENSE("GPL");
>> MODULE_DESCRIPTION("Driver for 93xx46 EEPROMs");
>> MODULE_AUTHOR("Anatolij Gustschin <agust@denx.de>");
>> -MODULE_ALIAS("spi:93xx46");
>
> This will break non DT users of this driver like
> drivers/misc/eeprom/digsy_mtc_eeprom.c
>
>> +MODULE_ALIAS("spi:eeprom-93xx46");
>>
>
> Can be a new entry.
>
Thank you for the comments. Addressed this by sending a follow up patch,
https://lore.kernel.org/patchwork/patch/1364431/
Thanks,
Aswath
next prev parent reply other threads:[~2021-01-13 5:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 16:39 [PATCH 0/2] misc: eeprom_93xx46: Enable module autoprobe Aswath Govindraju
2021-01-07 16:39 ` [PATCH 1/2] misc: eeprom_93xx46: Fix module alias to enable " Aswath Govindraju
2021-01-12 7:19 ` Vignesh Raghavendra
2021-01-13 5:15 ` Aswath Govindraju [this message]
2021-01-07 16:39 ` [PATCH 2/2] misc: eeprom_93xx46: Enable module autoprobe for microchip 93LC46B eeprom Aswath Govindraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487d20da-88d0-4d7b-8a39-b5a52f5cd63e@ti.com \
--to=a-govindraju@ti.com \
--cc=agust@denx.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=p.yadav@ti.com \
--cc=rdunlap@infradead.org \
--cc=vadym.kochan@plvision.eu \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).