* [PATCH v3] dt-bindings: usb: Add new compatible string for AM64 SoC
@ 2020-12-10 6:54 Aswath Govindraju
2020-12-11 3:37 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Aswath Govindraju @ 2020-12-10 6:54 UTC (permalink / raw)
Cc: Vignesh Raghavendra, Sekhar Nori, Aswath Govindraju,
Greg Kroah-Hartman, Rob Herring, Roger Quadros, linux-usb,
devicetree, linux-kernel
Add compatible string in j721e-usb binding file as the same USB subsystem
is present in AM64.
Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
Acked-by: Roger Quadros <rogerq@ti.com>
---
Changes since v2:
- added changes done over the versions
Changes since v1:
- replaced the '\t' at the beginning of the lines with spaces as it was
causing the dt_binding_check to fail
Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
index 388245b91a55..453587f6d304 100644
--- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
+++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
@@ -11,8 +11,11 @@ maintainers:
properties:
compatible:
- items:
- - const: ti,j721e-usb
+ anyOf:
+ - items:
+ - const: ti,j721e-usb
+ - items:
+ - const: ti,am64-usb
reg:
description: module registers
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: usb: Add new compatible string for AM64 SoC
2020-12-10 6:54 [PATCH v3] dt-bindings: usb: Add new compatible string for AM64 SoC Aswath Govindraju
@ 2020-12-11 3:37 ` Rob Herring
2020-12-11 6:10 ` Aswath Govindraju
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2020-12-11 3:37 UTC (permalink / raw)
To: Aswath Govindraju
Cc: Vignesh Raghavendra, Sekhar Nori, Greg Kroah-Hartman,
Roger Quadros, linux-usb, devicetree, linux-kernel
On Thu, Dec 10, 2020 at 12:24:50PM +0530, Aswath Govindraju wrote:
> Add compatible string in j721e-usb binding file as the same USB subsystem
> is present in AM64.
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> Acked-by: Roger Quadros <rogerq@ti.com>
> ---
>
> Changes since v2:
> - added changes done over the versions
>
> Changes since v1:
> - replaced the '\t' at the beginning of the lines with spaces as it was
> causing the dt_binding_check to fail
>
>
> Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> index 388245b91a55..453587f6d304 100644
> --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> @@ -11,8 +11,11 @@ maintainers:
>
> properties:
> compatible:
> - items:
> - - const: ti,j721e-usb
> + anyOf:
> + - items:
> + - const: ti,j721e-usb
> + - items:
> + - const: ti,am64-usb
compatible:
enum:
- ti,j721e-usb
- ti,am64-usb
>
> reg:
> description: module registers
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: usb: Add new compatible string for AM64 SoC
2020-12-11 3:37 ` Rob Herring
@ 2020-12-11 6:10 ` Aswath Govindraju
0 siblings, 0 replies; 3+ messages in thread
From: Aswath Govindraju @ 2020-12-11 6:10 UTC (permalink / raw)
To: Rob Herring
Cc: Vignesh Raghavendra, Sekhar Nori, Greg Kroah-Hartman,
Roger Quadros, linux-usb, devicetree, linux-kernel
Hi Rob,
On 11/12/20 9:07 am, Rob Herring wrote:
> On Thu, Dec 10, 2020 at 12:24:50PM +0530, Aswath Govindraju wrote:
>> Add compatible string in j721e-usb binding file as the same USB subsystem
>> is present in AM64.
>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> Acked-by: Roger Quadros <rogerq@ti.com>
>> ---
>>
>> Changes since v2:
>> - added changes done over the versions
>>
>> Changes since v1:
>> - replaced the '\t' at the beginning of the lines with spaces as it was
>> causing the dt_binding_check to fail
>>
>>
>> Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> index 388245b91a55..453587f6d304 100644
>> --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> @@ -11,8 +11,11 @@ maintainers:
>>
>> properties:
>> compatible:
>> - items:
>> - - const: ti,j721e-usb
>> + anyOf:
>> + - items:
>> + - const: ti,j721e-usb
>> + - items:
>> + - const: ti,am64-usb
>
> compatible:
> enum:
> - ti,j721e-usb
> - ti,am64-usb
>
Thank you for the comments.
I have sent a respin for this patch making the above changes.
May I please know a case where anyOf would be used rather than enum
because after reading the documentation[1], I thought that using enum
meant that only one of the listed strings in enum can be used as
compatible strings in a given node.
[1]https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/example-schema.yaml
Thanks,
Aswath
>>
>> reg:
>> description: module registers
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-11 6:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-10 6:54 [PATCH v3] dt-bindings: usb: Add new compatible string for AM64 SoC Aswath Govindraju
2020-12-11 3:37 ` Rob Herring
2020-12-11 6:10 ` Aswath Govindraju
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).