From: Jeremy Fitzhardinge <jeremy@goop.org>
To: "Gustavo F. Padovan" <gustavo@las.ic.unicamp.br>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [PATCH 0/24] x86: arch/x86/kernel/ cleanups
Date: Mon, 28 Jul 2008 14:17:50 -0700 [thread overview]
Message-ID: <488E377E.6060808@goop.org> (raw)
In-Reply-To: <1217279371-4410-1-git-send-email-gustavo@las.ic.unicamp.br>
Gustavo F. Padovan wrote:
> Ingo,
>
>
> Ingo,
>
> I removed many extra whitespaces and tabs from arch/x86/kernel/
>
This is not a good time to be posting this kind of patch. These kinds
of trivial cleanups are best done in a late -rc, when the patch rate
goes down. However, pure whitespace cleanups have very little value
like this, particularly since it looks like you're breaking the
formatting in some cases.
It would be better to address them in passing if there's some more
substantial change which needs to be done to the code.
http://janitor.kernelnewbies.org/ should be a good place to look for
suggestions.
J
next prev parent reply other threads:[~2008-07-28 21:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 21:09 [PATCH 0/24] x86: arch/x86/kernel/ cleanups Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 01/24] x86: kernel/alternative.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 02/24] x86: kernel/apm_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 03/24] x86: kernel/asm-offsets_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 04/24] x86: kernel/efi.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 05/24] x86: kernel/cpuid.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 06/24] x86: kernel/early-quirks.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 07/24] x86: kernel/io_apic_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 08/24] x86: kernel/io_apic_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 09/24] x86: kernel/irq_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 10/24] x86: kernel/irqinit_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 11/24] x86: kernel/kprobes.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 12/24] x86: kernel/microcode.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 13/24] x86: kernel/module_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 14/24] x86: kernel/pci-calgary_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 15/24] x86: kernel/probe_roms_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 16/24] x86: kernel/process_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 17/24] x86: kernel/process_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 18/24] x86: kernel/signal_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 19/24] x86: kernel/traps_64.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 20/24] x86: kernel/tsc.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 21/24] x86: kernel/visws_quirks.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 22/24] x86: kernel/vmi_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 23/24] x86: kernel/vmiclock_32.c cleanup Gustavo F. Padovan
2008-07-28 21:09 ` [PATCH 24/24] x86: kernel/sys_x86_64.c cleanup Gustavo F. Padovan
2008-07-29 1:47 ` [PATCH 11/24] x86: kernel/kprobes.c cleanup Masami Hiramatsu
2008-08-07 9:47 ` [PATCH 02/24] x86: kernel/apm_32.c cleanup Robert Richter
2008-07-28 21:17 ` Jeremy Fitzhardinge [this message]
2008-07-28 21:20 ` [PATCH 0/24] x86: arch/x86/kernel/ cleanups Ingo Molnar
2008-07-28 21:37 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488E377E.6060808@goop.org \
--to=jeremy@goop.org \
--cc=gustavo@las.ic.unicamp.br \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).