linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Paul Jackson <pj@sgi.com>
Cc: akpm@linux-foundation.org, menage@google.com,
	seto.hidetoshi@jp.fujitsu.com, laijs@cn.fujitsu.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] cpuset: clean up cpuset hierarchy traversal code
Date: Tue, 29 Jul 2008 09:30:38 +0800	[thread overview]
Message-ID: <488E72BE.9070108@cn.fujitsu.com> (raw)
In-Reply-To: <20080728010141.fbd33866.pj@sgi.com>

Paul Jackson wrote:
> Li Zefan wrote:
>> -	q = kfifo_alloc(number_of_cpusets * sizeof(cp), GFP_KERNEL, NULL);
> 
> 
> The block comment for rebuild_sched_domains() states:
> 
>> ... May take callback_mutex during
>> * call due to the kfifo_alloc() and kmalloc() calls.
> 
> I suspect that mention of kfifo_alloc() is no longer correct,
> with your patch.  If so, perhaps you could send a little additional
> fix patch, to remove that mention from the comment.
> 

Yes, but I just noticed Max removes that comment completely in his patch,
so I guess I can leave it as it is.


  parent reply	other threads:[~2008-07-29  1:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-28  2:47 [PATCH 1/3] cpuset: clean up cpuset hierarchy traversal code Li Zefan
2008-07-28  4:37 ` Paul Jackson
2008-07-28  5:12   ` Paul Jackson
2008-07-29  1:44     ` Li Zefan
2008-07-28  6:01 ` Paul Jackson
2008-07-28 17:20   ` Max Krasnyansky
2008-07-29  1:25     ` Li Zefan
2008-07-30 10:12     ` Paul Jackson
2008-07-29  1:30   ` Li Zefan [this message]
2008-07-29 13:04     ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488E72BE.9070108@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=pj@sgi.com \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).