From: Christoph Lameter <cl@linux-foundation.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Eric Sandeen <sandeen@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, mhalcrow@us.ibm.com,
stable@kernel.org
Subject: Re: [PATCH] eCryptfs - use page_alloc not kmalloc to get a page of memory
Date: Wed, 30 Jul 2008 09:48:41 -0500 [thread overview]
Message-ID: <48907F49.7020101@linux-foundation.org> (raw)
In-Reply-To: <488E3643.8000300@cs.helsinki.fi>
Pekka Enberg wrote:
>> For whatever reason, I did see non-page-aligned memory returned from
>> kmalloc(PAGE_CACHE_SIZE), and I think this is what caused the problem
>> once virt_to_page() was used to get hold of a page to pass around in the
>> ecryptfs/crypto code...
>
> With SLUB? I can't see how that's possible. I can see this with SLAB,
> though, for 4K pages.
It possible because PAGE_CACHE_SIZE is still handled by SLUB and if debugging is on then kmalloc may return non page aligned objects. The handoff to the page allocator only occurs for objects > 4k. We used to do this also for 4k objects but then we got performance regressions in tbench.
> In any case, the patch, of course, make sense as kmalloc() behavior
> varies between allocators.
>
> Pekka
next prev parent reply other threads:[~2008-07-30 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 16:13 [PATCH] eCryptfs - use page_alloc not kmalloc to get a page of memory Eric Sandeen
2008-07-28 16:25 ` Michael Halcrow
2008-07-28 16:53 ` Rik van Riel
2008-07-28 20:35 ` Andrew Morton
2008-07-28 20:38 ` Eric Sandeen
2008-07-28 20:42 ` Pekka Enberg
2008-07-28 21:03 ` Eric Sandeen
2008-07-28 21:12 ` Pekka Enberg
2008-07-30 14:48 ` Christoph Lameter [this message]
2008-07-30 14:39 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48907F49.7020101@linux-foundation.org \
--to=cl@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhalcrow@us.ibm.com \
--cc=penberg@cs.helsinki.fi \
--cc=sandeen@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).