linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Hancock <hancockr@shaw.ca>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Tomas Styblo <tripie@cpan.org>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	usb-storage@lists.one-eyed-alien.net
Subject: Re: [PATCH] JMicron JM20337 USB-SATA data corruption bugfix - device 152d:2338
Date: Wed, 30 Jul 2008 13:55:25 -0600	[thread overview]
Message-ID: <4890C72D.7040604@shaw.ca> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0807232337110.25883-100000@netrider.rowland.org>

Alan Stern wrote:
> On Wed, 23 Jul 2008, Robert Hancock wrote:
> 
>> It remains an issue, though, that if there's no underflow, if the device 
>> reports an error in the CSW but doesn't provide sense data, we assume 
>> nothing bad happened and don't retry. That definitely does not seem 
>> correct. The device is not supposed to do this, but with how crappily 
>> some of these devices are designed we should be more defensive.
> 
> The problem is, what can you do?  The device has said that something 
> was wrong, but it hasn't told you what.  Without knowing what went 
> wrong, you can't know how to recover.
> 
> I suppose in such cases we could simply report that the command failed
> completely.

I think that is what we need to do. The SCSI/block layers should retry 
the command or report a failure to userspace. Above all else we can't 
just continue on our merry way and assume success, otherwise data will 
get silently corrupted.

It could be that's what Windows is doing, and it's just silently 
retrying commands. Though, some people have reported corruption on these 
chipsets on Windows too, so maybe it has the same issue.

Is that SCSI/USB underflow fix from 
http://bugzilla.kernel.org/show_bug.cgi?id=9638 being pushed forward by 
anybody? If not, I can try and cook up a patch to take care of that as 
well as the non-underflow failed CSW/no sense data issue.

  reply	other threads:[~2008-07-30 19:55 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.eWQqoO1e4Mdhu8SK5jzMFAI/3NU@ifi.uio.no>
2008-07-21 19:37 ` [PATCH] JMicron JM20337 USB-SATA data corruption bugfix - device 152d:2338 Robert Hancock
2008-07-22  2:37   ` Alan Stern
2008-07-22  9:03     ` Tomas Styblo
2008-07-23  2:38       ` Alan Stern
2008-07-23 23:20         ` Robert Hancock
2008-07-24  3:42           ` Alan Stern
2008-07-30 19:55             ` Robert Hancock [this message]
2008-07-30 20:00               ` [usb-storage] " Matthew Dharm
2008-07-30 20:46                 ` Robert Hancock
2008-07-30 21:18                 ` Alan Stern
2008-07-30 21:07               ` Alan Stern
2008-08-01 21:15                 ` Alex Buell
2008-08-01 22:22                   ` Alex Buell
2008-08-02  2:32                     ` Robert Hancock
2008-08-02 23:49                     ` Alan Stern
2008-08-03  9:07                       ` Alex Buell
2008-08-04 16:48                         ` Alan Stern
2008-08-04 20:17                           ` Alex Buell
2008-08-04 20:45                             ` Alan Stern
2008-09-02 12:10                               ` Thiago Galesi
2008-09-02 15:02                                 ` Alan Stern
2008-09-02 16:07                                   ` Thiago Galesi
2008-09-02 19:19                                     ` Alan Stern
2008-09-02 20:16                                       ` Thiago Galesi
2008-09-02 21:06                                         ` Alan Stern
2008-09-04 12:09                                           ` Thiago Galesi
2008-09-04 14:03                                             ` Alan Stern
2008-09-04 15:17                                               ` Thiago Galesi
2008-09-04 15:26                                                 ` Alan Stern
2008-07-25  8:44           ` Tomas Styblo
2008-07-25  8:54             ` Robert Hancock
2008-07-22  5:11   ` Tomas Styblo
2008-07-22  5:31     ` Robert Hancock
2008-07-22  6:11       ` Tomas Styblo
2008-07-22  8:45         ` Robert Hancock
2008-07-24  6:15           ` Alex Buell
2008-07-29 21:09           ` Alex Buell
2008-07-29 22:33             ` [usb-storage] " Matthew Dharm
2008-07-20  5:13 Tomas Styblo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4890C72D.7040604@shaw.ca \
    --to=hancockr@shaw.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tripie@cpan.org \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).