From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E22C0C433EF for ; Wed, 23 Feb 2022 17:15:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243321AbiBWRPa (ORCPT ); Wed, 23 Feb 2022 12:15:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233071AbiBWRP0 (ORCPT ); Wed, 23 Feb 2022 12:15:26 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C764C10B8 for ; Wed, 23 Feb 2022 09:14:58 -0800 (PST) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 83988407AB for ; Wed, 23 Feb 2022 17:14:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645636497; bh=5kSScfu1ynBQhlMwgNQcTZQZ+l099L/p5FFilnRHLoA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vRgTyL5sBow3V0Ou/RDwNbMNMDscI8zAm5rwwrnDCqLFIfJVgiexBMm1EE0Nw0yos 0DTvnf7itbC1df/v2BUFtz7meeuJDmWt7uJSDlYUwkCmm0T8cJ+oylLry2iMdY40kF 5eHoarUZwSVJYd2GoZTHfJXMb1wgHqBqkuX1APYsQvQqBpiwtyZsH2zUZwRkdWpJUq ZYWURDzbkEUu4S2BXtLZEWM6sPeCUqIaPLH+rpt0er8Io9CPszz9LB80PRWtqk1ZaN 2A9HDQAsgIDSkhc7DN2IYBPnIjCaeHBVd1HgOwL9aGzLAQwknQ33xPhvfw7X70td4p BccgJetsLxV1w== Received: by mail-ej1-f70.google.com with SMTP id i20-20020a17090671d400b006d0ed9c68c1so4100623ejk.14 for ; Wed, 23 Feb 2022 09:14:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5kSScfu1ynBQhlMwgNQcTZQZ+l099L/p5FFilnRHLoA=; b=qCUJ2kDw/raYP3hzxVHYzfcFFIw4CbIbi6fXR3mpR7KGKaoChLgohpPqW+Vw+V7Vbp VlSnp+tyGC59Z/hoWptalKGjX3BaNcSX/sbFJVIYup80UTDkF3Y4c9w7qZpPvrNyae68 KVAQ1WjbTKul2AfjWssSiAc4DYnhDc/7pVIYawDSQ2HEe4//RHdv/IT+zvUQbT/ZWQAe cpzXN79Ql/gy+ApiiobW2n/LZAgxbCnfhjZrCTDQd7ulbPJ/XswpN8A5AIexJ4ld93QJ Zy7N+FjJk0PTgu4AVoDvJ6YQ8hy0DMdLLNMmM8L0J00X6fKJbaDyxQnnRVILTzn4sVb1 W8Sw== X-Gm-Message-State: AOAM531d5blVk2Nhd2KkZ6+ZffMfGdjxonz5zUHzHpVhJVoh4RPyclSn txh6Nu1lhIZgXuupVyBqLpQEgn8KWbqffEYCHAoZPgs+w9DKIFWPg0gixNGU2YmbUneNmwtKqq5 avQoJZ3iiVhzA+BTVvVEA95dEnsVyq5q+5Z0h50zX6Q== X-Received: by 2002:a05:6402:2801:b0:410:a592:a5d0 with SMTP id h1-20020a056402280100b00410a592a5d0mr377409ede.253.1645636496648; Wed, 23 Feb 2022 09:14:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJw8C6Speh5imj9uL4wV+FW7pUUwz5jAm+B3l/R97H1WjbJ/dMmrgtO2TdF852Q8eYfTqYzdmQ== X-Received: by 2002:a05:6402:2801:b0:410:a592:a5d0 with SMTP id h1-20020a056402280100b00410a592a5d0mr377389ede.253.1645636496477; Wed, 23 Feb 2022 09:14:56 -0800 (PST) Received: from [192.168.0.126] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id w14sm98641eji.125.2022.02.23.09.14.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Feb 2022 09:14:55 -0800 (PST) Message-ID: <4896ee6e-3395-8d67-8926-4a09f02d7cdd@canonical.com> Date: Wed, 23 Feb 2022 18:14:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 2/2] dt-bindings: hwmon: Add sample averaging property for ADM1275 Content-Language: en-US To: Potin Lai , Guenter Roeck , Jean Delvare , Rob Herring Cc: Patrick Williams , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220223163817.30583-1-potin.lai@quantatw.com> <20220223163817.30583-3-potin.lai@quantatw.com> From: Krzysztof Kozlowski In-Reply-To: <20220223163817.30583-3-potin.lai@quantatw.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/02/2022 17:38, Potin Lai wrote: > Add binding information for "pwr-avg" and "vi-avg" properties > > Signed-off-by: Potin Lai > --- > .../devicetree/bindings/hwmon/adi,adm1275.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > index 223393d7cafd..2525a67a880e 100644 > --- a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > @@ -37,6 +37,14 @@ properties: > description: > Shunt resistor value in micro-Ohm. > > + vi-avg: > + description: > + Sample averaging for current and voltage. Both do not look like generic properties, so you need: - type - vendor prefix ("adi,") - maximum value? It would be nice to actually explain what this value means - number of readings for each averaging (unless it is obvious in the domain...)? Does the hardware have default value? > + > + pwr-avg: > + description: > + Sample averaging for power. > + > required: > - compatible > - reg > @@ -53,5 +61,7 @@ examples: > compatible = "adi,adm1272"; > reg = <0x10>; > shunt-resistor-micro-ohms = <500>; > + vi-avg = <128>; > + pwr-avg = <128>; > }; > }; Best regards, Krzysztof