From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754072AbYJQJXE (ORCPT ); Fri, 17 Oct 2008 05:23:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752472AbYJQJWy (ORCPT ); Fri, 17 Oct 2008 05:22:54 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:63705 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752269AbYJQJWx (ORCPT ); Fri, 17 Oct 2008 05:22:53 -0400 Message-ID: <48F8591E.7090008@cn.fujitsu.com> Date: Fri, 17 Oct 2008 17:21:34 +0800 From: Zhaolei User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Russell King , "linux-kernel@vger.kernel.org" Subject: [PATCH] Fix debugfs_create_file's error checking method for arm/mach-ns9xxx Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, debugfs_create_file() returns NULL if an error occurs, returns -ENODEV when debugfs is not enabled in the kernel. Signed-off-by: Zhao Lei --- arch/arm/mach-ns9xxx/clock.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-ns9xxx/clock.c b/arch/arm/mach-ns9xxx/clock.c index 44ed20d..15945e9 100644 --- a/arch/arm/mach-ns9xxx/clock.c +++ b/arch/arm/mach-ns9xxx/clock.c @@ -208,7 +208,11 @@ static int __init clk_debugfs_init(void) dentry = debugfs_create_file("clk", S_IFREG | S_IRUGO, NULL, NULL, &clk_debugfs_operations); - return IS_ERR(dentry) ? PTR_ERR(dentry) : 0; + if (!dentry) + return -ENOMEM; + if (IS_ERR(dentry)) + return PTR_ERR(dentry); + return 0; } subsys_initcall(clk_debugfs_init); -- 1.5.5.3