From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbdATOA5 (ORCPT ); Fri, 20 Jan 2017 09:00:57 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:50977 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752495AbdATOAz (ORCPT ); Fri, 20 Jan 2017 09:00:55 -0500 Subject: Re: [PATCH] clk: samsung: exynos5420: Mark CLK_ACLK432_SCALER as CLK_IS_CRITICAL To: Sylwester Nawrocki , Michael Turquette , Stephen Boyd References: <1484908891-11820-1-git-send-email-javier@osg.samsung.com> <551ac156-0cfa-29be-335f-d8a1f171cd8a@samsung.com> <0ffa0d28-1086-887c-dcfc-590b6146b03e@samsung.com> Cc: linux-kernel@vger.kernel.org, Inki Dae , Andi Shyti , Shuah Khan , Mauro Carvalho Chehab , Marek Szyprowski , Kukjin Kim , Chanwoo Choi , linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Tomasz Figa , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org From: Javier Martinez Canillas Message-ID: <48a2f141-4275-cb79-aafd-62191d747107@osg.samsung.com> Date: Fri, 20 Jan 2017 11:00:38 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <0ffa0d28-1086-887c-dcfc-590b6146b03e@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sylwester, On 01/20/2017 10:55 AM, Sylwester Nawrocki wrote: > On 01/20/2017 01:32 PM, Sylwester Nawrocki wrote: >> On 01/20/2017 11:41 AM, Javier Martinez Canillas wrote: >>> On Exynos5800 SoC the SCALER block uses 2 input clocks: CLK_ACLK_300_GSCL >>> and CLK_ACLK432_SCALER, so both needs to be ungated in order to access it. >>> >>> But Exynos5420 only has the CLK_ACLK_300_GSCL as gsc_pd clk. So just using >>> this definition from exynos5420.dtsi in Exynos5800 leads to the following: >> [...] >>> So until a proper solution based on runtime PM gets merged, mark the clock >>> as critical to prevent it to be gated. >>> >>> Suggested-by: Marek Szyprowski >>> Signed-off-by: Javier Martinez Canillas >> >> Acked-by: Sylwester Nawrocki > > Oops, the $subject patch can be dropped since as Marek just pointed out > to me the changes introduced by that patch are already included in a patch > which is already in the v4.10 fixes queue: > > https://git.kernel.org/cgit/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=318fa46cc60d37fec1e87dbf03a82aca0f5ce695 > Yes, I just answered to Marek in the other thread saying the same. He did mention the patch could fix the issue but for some reason I didn't see the CLK_ACLK_300_GSCL in the clocks marked as critical... Anyways, sorry for the noise. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America