linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Alex Elder <elder@linaro.org>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com
Cc: andersson@kernel.org, agross@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, elder@kernel.org,
	linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Luca Weiss <luca.weiss@fairphone.com>
Subject: Re: [PATCH net-next 2/2] net: ipa: add IPA v4.7 support
Date: Sat, 10 Dec 2022 10:31:14 +0100	[thread overview]
Message-ID: <48bef9dd-b71c-b6aa-e853-1cf821e88b50@linaro.org> (raw)
In-Reply-To: <fa6d342e-0cfe-b870-b044-b0af476e3905@linaro.org>



On 9.12.2022 21:22, Alex Elder wrote:
> On 12/8/22 3:22 PM, Konrad Dybcio wrote:
>>
>>
>> On 8.12.2022 22:15, Alex Elder wrote:
>>> Add the necessary register and data definitions needed for IPA v4.7,
>>> which is found on the SM6350 SoC.
>>>
>>> Co-developed-by: Luca Weiss <luca.weiss@fairphone.com>
>>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>>> Signed-off-by: Alex Elder <elder@linaro.org>
>>> ---
>> [...]
>>> +
>>> +/* Memory configuration data for an SoC having IPA v4.7 */
>>> +static const struct ipa_mem_data ipa_mem_data = {
>>> +    .local_count    = ARRAY_SIZE(ipa_mem_local_data),
>>> +    .local        = ipa_mem_local_data,
>>> +    .imem_addr    = 0x146a9000,
>>> +    .imem_size    = 0x00002000,
>> Should probably be
>>
>> 0x146a8000
>> 0x00003000
>>
>> with an appropriate change in dt to reserve that region.
>>
>> Qualcomm does:
>> ipa@... { qcom,additional-mapping = <0x146a8000 0x146a8000 0x2000>; };
>>
>> which covers 0x146a8000-0x146a9fff
>>
>> plus
>>
>> imem@.. { reg = <0x146aa000 0x1000>; };
>>
>> which in total gives us 0x146a8000-0x146aafff
> 
> Can you tell me where you found this information?
[1], [2]

> 
>> That would also mean all of your writes are kind of skewed, unless
>> you already applied some offsets to them.
> 
> This region is used by the modem, but must be set up
> by the AP.
> 
>> (IMEM on 6350 starts at 0x14680000 and is 0x2e000 long, as per
>> the bootloader memory map)
> 
> On SM7250 (sorry, I don't know about 7225, or 6350 for that matter),
> the IMEM starts at 0x14680000 and has length 0x2c000.  However that
> memory is used by multiple entities.  The portion set aside for IPA
> starts at 0x146a9000 and has size 0x2000.
> 
Not sure how 7250 relates to 6350, but I don't think there's much
overlap..


Konrad

[1] https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.9.12.r1/arch/arm64/boot/dts/qcom/lagoon.dtsi#L3698-L3707

[2] https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.9.12.r1/arch/arm64/boot/dts/qcom/lagoon.dtsi#L1004-L1045
>                     -Alex
> 
>> Konrad
> 

  reply	other threads:[~2022-12-10  9:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-08 21:15 [PATCH net-next 0/2] net: ipa: enable IPA v4.7 support Alex Elder
2022-12-08 21:15 ` [PATCH net-next 1/2] dt-bindings: net: qcom,ipa: Add SM6350 compatible Alex Elder
2022-12-09  8:24   ` Krzysztof Kozlowski
2022-12-30 20:50   ` Caleb Connolly
2022-12-08 21:15 ` [PATCH net-next 2/2] net: ipa: add IPA v4.7 support Alex Elder
2022-12-08 21:22   ` Konrad Dybcio
2022-12-09 20:22     ` Alex Elder
2022-12-10  9:31       ` Konrad Dybcio [this message]
2022-12-12 23:54         ` Jakub Kicinski
2022-12-13  1:11           ` Alex Elder
2022-12-30 17:28         ` Alex Elder
2022-12-30 23:53           ` Alex Elder
2022-12-13  0:00 ` [PATCH net-next 0/2] net: ipa: enable " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48bef9dd-b71c-b6aa-e853-1cf821e88b50@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=elder@kernel.org \
    --cc=elder@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).