linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mark Brown <broonie@kernel.org>,
	alsa-devel@alsa-project.org, info@andromedabox.org,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Eric Miao <eric.y.miao@gmail.com>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Jaroslav Kysela <perex@perex.cz>,
	linux-kernel@vger.kernel.org, Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64
Date: Thu, 23 Feb 2017 15:45:56 +0100	[thread overview]
Message-ID: <48c91f5d-6ff3-af67-c4eb-4e958a7de465@suse.de> (raw)
In-Reply-To: <s5hefyp6l4i.wl-tiwai@suse.de>

Am 23.02.2017 um 15:24 schrieb Takashi Iwai:
> On Thu, 23 Feb 2017 15:11:46 +0100,
> Andreas Färber wrote:
>> Am 22.02.2017 um 19:47 schrieb Mark Brown:
>>> Please use subject lines matching the style for the subsystem.  This
>>> makes it easier for people to identify relevant patches.
>>
>> Should I make it "ASoC: pxa: ..." then? SND_MMP_SOC selects SND_ARM,
>> which in sound/arm/Kconfig says 'Drivers that are implemented on ASoC
>> can be found in "ALSA for SoC audio support" section.', which confused
>> me about whether or not this is an ASoC compliant driver if it selects a
>> non-ASoC symbol.
> 
> It's a bug that selects SND_ARM there.  I guess this was wrongly taken
> from the old example of AC97 ARM SoC code, which was fixed later.
> ASoC stuff is basically irrelevant from the legacy sound/arm/*.

Thanks, Takashi-san. I'll update as follows then.

diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig
index f8e1c06..aba7213 100644
--- a/sound/soc/pxa/Kconfig
+++ b/sound/soc/pxa/Kconfig
@@ -9,10 +9,9 @@ config SND_PXA2XX_SOC

 config SND_MMP_SOC
        bool "SoC Audio for Marvell MMP chips"
-       depends on ARCH_MMP && ARM
-       select MMP_SRAM
+       depends on ARCH_MMP || COMPILE_TEST
+       select MMP_SRAM if ARM
        select SND_SOC_GENERIC_DMAENGINE_PCM
-       select SND_ARM
        help
          Say Y if you want to add support for codecs attached to
          the MMP SSPA interface.

Okay to do that in one patch or break up into three?

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

  reply	other threads:[~2017-02-23 14:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22  2:29 [PATCH v2 0/8] ARM64: Initial Marvell IAP140 enablement Andreas Färber
2017-02-22  2:29 ` [PATCH v2 1/8] Documentation: arm: Marvell: Document IAP140 Andreas Färber
2017-02-22  2:29 ` [PATCH v2 2/8] tty: serial: Suppress deprecated SERIAL_PXA on arm64 Andreas Färber
2017-02-22  2:29 ` [PATCH v2 3/8] tty: serial: 8250_pxa: Implement mmp earlycon Andreas Färber
2017-02-22  2:29 ` [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64 Andreas Färber
2017-02-22 18:47   ` Mark Brown
2017-02-23 14:11     ` Andreas Färber
2017-02-23 14:24       ` Takashi Iwai
2017-02-23 14:45         ` Andreas Färber [this message]
2017-02-22  2:29 ` [PATCH v2 5/8] ARM64: Prepare Marvell IAP140 aka PXA1908 Andreas Färber
2017-02-22  2:29 ` [PATCH v2 6/8] Documentation: devicetree: arm: marvell: Document IAP140 Andreas Färber
2017-02-27 22:31   ` Rob Herring
2017-02-22  2:29 ` [PATCH v2 7/8] ARM64: dts: marvell: Add IAP140 and Andromeda Box Edge Andreas Färber
2017-02-22  2:29 ` [PATCH v2 8/8] ARM64: dts: marvell: iap140-andromeda-box-edge: Add uart0 clock Andreas Färber
2017-02-22 13:34 ` [PATCH v2 0/8] ARM64: Initial Marvell IAP140 enablement Rob Herring
2017-02-22 16:43   ` Andreas Färber
2017-02-22 16:48     ` Andreas Färber
2017-02-22 19:27     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48c91f5d-6ff3-af67-c4eb-4e958a7de465@suse.de \
    --to=afaerber@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=daniel@zonque.org \
    --cc=eric.y.miao@gmail.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=info@andromedabox.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robert.jarzmik@free.fr \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).