From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 485F7C43461 for ; Mon, 17 May 2021 07:29:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2725E611C2 for ; Mon, 17 May 2021 07:29:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235269AbhEQHbC (ORCPT ); Mon, 17 May 2021 03:31:02 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:60780 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230527AbhEQHbB (ORCPT ); Mon, 17 May 2021 03:31:01 -0400 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14H7C2Y0012348; Mon, 17 May 2021 09:29:29 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=IBklEhJOoqnRyM5eXyLESodNBjnwwQeXasaYr+V1Hs8=; b=AXloOSyjoJBa8hQbEwYVFThW80uykJN6iVPny5RTPDvvzEuUAG2oPtk4xmHFuGF7AoJ1 aIkKBc+W8RoTown7zPNJmSxbpGK8xeNanQ92dHzxrernkIElpge/31I8CDumzyI3a/0X BgvlrEqU9ZJYqvN+7EFaW4yh0DTtvF7H6JWbLPYL6ek+RhL0xfmx/66qFhs/yrAtcUd4 XnRviqW2iaRTVxSnEz59/QU/vWOIFsV9BJw1ICHfS25lFqvMUuGDmlVxQs83ttA/N6uX 44PybUlC573C6fw9oCoe5ZMUWbe8GjXDfzK9fxUjzfezG7CIM/4a44x9PTx2ePPGpF0c Lg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38k5dq34pu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 May 2021 09:29:29 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E4D53100034; Mon, 17 May 2021 09:29:26 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id B4B34214D36; Mon, 17 May 2021 09:29:26 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.47) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 17 May 2021 09:29:25 +0200 Subject: Re: [PATCH v2 1/3] spi: spi-mem: add automatic poll status functions To: Boris Brezillon CC: Mark Brown , Miquel Raynal , Vignesh Raghavendra , , Alexandre Torgue , , , , , References: <20210507131756.17028-1-patrice.chotard@foss.st.com> <20210507131756.17028-2-patrice.chotard@foss.st.com> <20210508095506.4d0d628a@collabora.com> <542000b4-1a65-5090-72f9-441c75ee1098@foss.st.com> <20210510112249.5613978e@collabora.com> From: Patrice CHOTARD Message-ID: <48d8774c-9868-27e5-b8b0-fdbf99c84ba2@foss.st.com> Date: Mon, 17 May 2021 09:29:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210510112249.5613978e@collabora.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-05-17_01:2021-05-12,2021-05-17 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris On 5/10/21 11:22 AM, Boris Brezillon wrote: > On Mon, 10 May 2021 10:46:48 +0200 > Patrice CHOTARD wrote: > >>> >>>> + >>>> + if (ctlr->mem_ops && ctlr->mem_ops->poll_status) { >>>> + ret = spi_mem_access_start(mem); >>>> + if (ret) >>>> + return ret; >>>> + >>>> + reinit_completion(&ctlr->xfer_completion); >>>> + >>>> + ret = ctlr->mem_ops->poll_status(mem, op, mask, match, >>>> + timeout_ms); >>>> + >>>> + ms = wait_for_completion_timeout(&ctlr->xfer_completion, >>>> + msecs_to_jiffies(timeout_ms)); >>> >>> Why do you need to wait here? I'd expect the poll_status to take care >>> of this wait. >> >> It was a request from Mark Brown [1]. The idea is to implement >> similar mechanism already used in SPI framework. > > Well, you have to choose, either you pass a timeout to ->poll_status() > and let the driver wait for the status change (and return -ETIMEDOUT if > it didn't happen in time), or you do it here and the driver only has to > signal the core completion object. I think it's preferable to let the > driver handle the timeout though, because you don't know how the > status check will be implemented, and it's not like the > reinit_completion()+wait_for_completion_timeout() done here would > greatly simplify the drivers wait logic anyway. > Ok i will remove the reinit/wait_completion() as you suggested. Thanks Patrice