From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07452C2D0E4 for ; Tue, 17 Nov 2020 20:09:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A30E0204EC for ; Tue, 17 Nov 2020 20:09:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731668AbgKQUJs (ORCPT ); Tue, 17 Nov 2020 15:09:48 -0500 Received: from mga14.intel.com ([192.55.52.115]:52554 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725771AbgKQUJk (ORCPT ); Tue, 17 Nov 2020 15:09:40 -0500 IronPort-SDR: WEQUiQ3H56pqv+2XcHu46YwybbBkwtwQPaDT6DQ2eGtq8AdM1zbyl/mW9XjYD9V4NRy0FOVu2P 8Oa483xs3DXg== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="170218589" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="170218589" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 12:09:38 -0800 IronPort-SDR: AedYloQk0uay8k80y+5yad5blsk57KKzVdIsE+hDtTPjkm5VVhZE/bBy3DJY5BG/8Bdt6oIdYb 6MStRu0jo0hA== X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="544192023" Received: from chimtrax-mobl.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.254.101.222]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 12:09:38 -0800 Subject: Re: [PATCH v11 03/16] PCI/RCEC: Bind RCEC devices to the Root Port driver To: Sean V Kelley , bhelgaas@google.com, Jonathan.Cameron@huawei.com, xerces.zhao@gmail.com, rafael.j.wysocki@intel.com, ashok.raj@intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@intel.com, qiuxu.zhuo@intel.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201117191954.1322844-1-sean.v.kelley@intel.com> <20201117191954.1322844-4-sean.v.kelley@intel.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: <49044b64-dfd4-18ec-5b0a-8aaca304df11@linux.intel.com> Date: Tue, 17 Nov 2020 12:09:35 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201117191954.1322844-4-sean.v.kelley@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/17/20 11:19 AM, Sean V Kelley wrote: > From: Qiuxu Zhuo > > If a Root Complex Integrated Endpoint (RCiEP) is implemented, it may signal > errors through a Root Complex Event Collector (RCEC). Each RCiEP must be > associated with no more than one RCEC. > > For an RCEC (which is technically not a Bridge), error messages "received" > from associated RCiEPs must be enabled for "transmission" in order to cause > a System Error via the Root Control register or (when the Advanced Error > Reporting Capability is present) reporting via the Root Error Command > register and logging in the Root Error Status register and Error Source > Identification register. > > Given the commonality with Root Ports and the need to also support AER and > PME services for RCECs, extend the Root Port driver to support RCEC devices > by adding the RCEC Class ID to the driver structure. > > Co-developed-by: Sean V Kelley > Link: https://lore.kernel.org/r/20201002184735.1229220-3-seanvk.dev@oregontracks.org > Signed-off-by: Sean V Kelley > Signed-off-by: Qiuxu Zhuo > Signed-off-by: Bjorn Helgaas > Reviewed-by: Jonathan Cameron Reviewed-by: Kuppuswamy Sathyanarayanan > --- > drivers/pci/pcie/portdrv_pci.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c > index 3a3ce40ae1ab..4d880679b9b1 100644 > --- a/drivers/pci/pcie/portdrv_pci.c > +++ b/drivers/pci/pcie/portdrv_pci.c > @@ -106,7 +106,8 @@ static int pcie_portdrv_probe(struct pci_dev *dev, > if (!pci_is_pcie(dev) || > ((pci_pcie_type(dev) != PCI_EXP_TYPE_ROOT_PORT) && > (pci_pcie_type(dev) != PCI_EXP_TYPE_UPSTREAM) && > - (pci_pcie_type(dev) != PCI_EXP_TYPE_DOWNSTREAM))) > + (pci_pcie_type(dev) != PCI_EXP_TYPE_DOWNSTREAM) && > + (pci_pcie_type(dev) != PCI_EXP_TYPE_RC_EC))) > return -ENODEV; > > status = pcie_port_device_register(dev); > @@ -195,6 +196,8 @@ static const struct pci_device_id port_pci_ids[] = { > { PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x00), ~0) }, > /* subtractive decode PCI-to-PCI bridge, class type is 060401h */ > { PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x01), ~0) }, > + /* handle any Root Complex Event Collector */ > + { PCI_DEVICE_CLASS(((PCI_CLASS_SYSTEM_RCEC << 8) | 0x00), ~0) }, > { }, > }; > > -- Sathyanarayanan Kuppuswamy Linux Kernel Developer