From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "Horia Geantă" <horia.geanta@nxp.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-imx@nxp.com
Subject: Re: [PATCH] swiotlb: sync buffer when mapping FROM_DEVICE
Date: Thu, 23 May 2019 19:05:49 +0100 [thread overview]
Message-ID: <49076a29-a0f5-f5f0-6c2a-a2180edd1674@arm.com> (raw)
In-Reply-To: <20190523164332.GA22245@lst.de>
On 23/05/2019 17:43, Christoph Hellwig wrote:
> On Thu, May 23, 2019 at 07:35:07AM +0200, Marek Szyprowski wrote:
>> Don't we have DMA_BIDIRECTIONAL for such case?
>
> Not sure if it was intended for that case, but it definitively should
> do the right thing for swiotlb, and it should also do the right thing
> in terms of cache maintainance.
>
>> Maybe we should update
>> documentation a bit to point that DMA_FROM_DEVICE expects the whole
>> buffer to be filled by the device?
>
> Probably. Horia, can you try to use DMA_BIDIRECTIONAL?
>
Yes, in general that should be a viable option. I got rather focused on
the distinction that a "partial" FROM_DEVICE mapping would still be
allowed to physically prevent the device from making any reads, whereas
BIDIRECTIONAL would not, but I suspect any benefit being lost there is
mostly one of debugging visibility rather than appreciable security, and
probably not enough to justify additional complexity on its own - I
couldn't say off-hand how many IOMMUs actually support write-only
permissions anyway.
Whichever way, I'd certainly have no objection to formalising what seems
to be the existing behaviour (both SWIOTLB and ARM dmabounce look
consistent, at least) as something like "for the DMA_FROM_DEVICE
direction, any parts of the buffer not written to by the device will
become undefined". The IOMMU bounce page stuff is going to be another
one in this boat, too.
Robin.
prev parent reply other threads:[~2019-05-23 18:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 7:20 [PATCH] swiotlb: sync buffer when mapping FROM_DEVICE Horia Geantă
2019-05-22 12:32 ` Christoph Hellwig
2019-05-22 12:50 ` Robin Murphy
2019-05-22 13:09 ` Christoph Hellwig
2019-05-22 13:25 ` Robin Murphy
2019-05-22 13:34 ` Christoph Hellwig
2019-05-22 13:55 ` Robin Murphy
2019-05-23 5:35 ` Marek Szyprowski
2019-05-23 16:25 ` Horia Geanta
2019-05-23 16:43 ` Christoph Hellwig
2019-05-23 17:53 ` Horia Geanta
2019-05-23 18:05 ` Robin Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49076a29-a0f5-f5f0-6c2a-a2180edd1674@arm.com \
--to=robin.murphy@arm.com \
--cc=hch@lst.de \
--cc=horia.geanta@nxp.com \
--cc=iommu@lists.linux-foundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).