From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752060AbcGMNJv (ORCPT ); Wed, 13 Jul 2016 09:09:51 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:49208 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbcGMNJm (ORCPT ); Wed, 13 Jul 2016 09:09:42 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: tiffany lin , linux-kernel@vger.kernel.org, Hans Verkuil , PoChun Lin , Matthias Brugger , linux-mediatek@lists.infradead.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [PATCH] [media] mtk-vcodec: fix type mismatches Date: Wed, 13 Jul 2016 15:08:09 +0200 Message-ID: <4915511.9pXBipIRF8@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1468403786.32454.16.camel@mtksdaap41> References: <20160711213959.2481081-1-arnd@arndb.de> <1468403786.32454.16.camel@mtksdaap41> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ym3NfCjoVTVgwl7gMefginbv9ElVhv1aVgGY8d83oy+5qDsmyuK 5ylX6Pw9NGUlM8riTt+nQbFTTlQ1mp8c1a9daD/qtHprSO3OU/CnHBhJ9PodNPjXgK2BCOc L0H77OhVFhltrtmZiOIIoKM59EQnGBcHR8VA1R4KfbCqGbtknLthumHJ3inUUURmS2wUu93 6l/8DQfTq/zNSeD99oWBw== X-UI-Out-Filterresults: notjunk:1;V01:K0:M6m/wZfS/Pk=:mgSbzfnqnV6yQ6WX1SMbQx cg3Y40Nj8fUFfTxEPtVg1msCc01EyZfPw833vn5gBmOE1fPacQ/5KYQaLLsSc37j7rJht5ZiX gMiXfWNjZcW3jeMEnV6FRm+k+ZFoMYxWyT4QwYx4875NIzcS7UI02O04X0L+9KFsAr14RPdni hgennU8taWY5d+18A69IjRZNOuTUtsmDwqgoNXkyZJ1KoP6kefh9A/Y5x84rUoEBFWsoyEUeV 6k7l5w4D7NjMp4Qjaivmw/pTT9Xu2uk4cYbv9yrcgt2lyJFtF8u6oZREfcMlOmrBvHc34GaAi fUWtTBkxSIJlEOhfxzJQklWDSbpnP1ne3D3B31Lwtyw70KAAXs6FTYNB+Dq/rMw83SRObKrGJ ULMiSs4qhMYPqtf1bS/vSBbGSHZ6M9VVeXzCJ2vOTpxt3TlklPZQjsBRZ3HLVSMc72ha1BVK8 Pfy88PM/jlhJV1pcejvGSQkxs6ZBL9+/USa89ckA+retmj9VpeB5oj9HfqADVKuyRqu+q96Xy +riq4ZnrVAHn0T7ouf4tnfzgXtYaAFQzx/T4yDm2MQamlTSimvQBWRCD9t0MLNL3pWhM8BsVZ w8jlhWeQCvn2T5apViD6kmRrb0oCpha/XDwbCLemf1vPW3OzbFIJXUQFR6BvyIOBti4y6QMaF wKpXabjnn3NhGBK3d26tcIKEp9aTh+dvrPTyfTy19rvjmSH891SUposCMlC7jdQn0LwjcsdZh Iz5sWQ23KuVVC/D6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, July 13, 2016 5:56:26 PM CEST tiffany lin wrote: > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > index 6dcae0a0a1f2..0b25a8700877 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > @@ -1028,15 +1028,15 @@ static void mtk_venc_worker(struct work_struct *work) > > bs_buf.size = (size_t)dst_buf->planes[0].length; > > > > mtk_v4l2_debug(2, > > - "Framebuf VA=%p PA=%llx Size=0x%lx;VA=%p PA=0x%llx Size=0x%lx;VA=%p PA=0x%llx Size=%zu", > > + "Framebuf VA=%p PA=%pad Size=0x%zx;VA=%p PA=%pad Size=0x%zx;VA=%p PA=%pad Size=0x%zx", > > frm_buf.fb_addr[0].va, > > - (u64)frm_buf.fb_addr[0].dma_addr, > > + &frm_buf.fb_addr[0].dma_addr, > > frm_buf.fb_addr[0].size, > > frm_buf.fb_addr[1].va, > > - (u64)frm_buf.fb_addr[1].dma_addr, > > + &frm_buf.fb_addr[1].dma_addr, > > frm_buf.fb_addr[1].size, > > frm_buf.fb_addr[2].va, > > - (u64)frm_buf.fb_addr[2].dma_addr, > > + &frm_buf.fb_addr[2].dma_addr, > > frm_buf.fb_addr[2].size); > This change will make debug message dump address of dma_addr field but > not the value of the dma_addr we want. > How about change it from > PA=%llx -> PA=%u > (u64)frm_buf.fb_addr[0].dma_addr -> (u32)frm_buf.fb_addr[0].dma_addr, > The %llx works fine with the cast to u64, the change above is mainly for the "%lx" on a size_t causing a warning. The change to %pad is done in order to use a consistent output for the dma_addr_t, which had a leading "0x" in two cases but not in the first one. printk interprets %pad as a pointer to a dma_addr_t and prints the address, not the pointer to it, see Documentation/printk-formats.txt, which lets you avoid the type cast as well as the 0x. Arnd