From: Daniel Borkmann <firstname.lastname@example.org> To: Matt Cover <email@example.com>, Kumar Kartikeya Dwivedi <firstname.lastname@example.org> Cc: Alexei Starovoitov <email@example.com>, "David S. Miller" <firstname.lastname@example.org>, Jakub Kicinski <email@example.com>, Jesper Dangaard Brouer <firstname.lastname@example.org>, John Fastabend <email@example.com>, Andrii Nakryiko <firstname.lastname@example.org>, Martin KaFai Lau <email@example.com>, Song Liu <firstname.lastname@example.org>, Yonghong Song <email@example.com>, KP Singh <firstname.lastname@example.org>, Lorenzo Bianconi <email@example.com>, Matthew Cover <firstname.lastname@example.org>, netdev <email@example.com>, bpf <firstname.lastname@example.org>, LKML <email@example.com> Subject: Re: [PATCH bpf-next] samples/bpf: xdp_redirect_cpu: Add mprog-disable to optstring. Date: Thu, 5 Aug 2021 00:50:31 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CAGyo_hp2Uunp0_McN3J8MjSeF593thwiODfUaiE-u_NXArEDPg@mail.gmail.com> On 8/4/21 7:57 PM, Matt Cover wrote: > On Sat, Jul 31, 2021 at 8:25 AM Kumar Kartikeya Dwivedi > <email@example.com> wrote: >> >> On Sat, Jul 31, 2021 at 06:26:32AM IST, Matthew Cover wrote: >>> Commit ce4dade7f12a ("samples/bpf: xdp_redirect_cpu: Load a eBPF program >>> on cpumap") added the following option, but missed adding it to optstring: >>> - mprog-disable: disable loading XDP program on cpumap entries >>> >>> Add the missing option character. >> >> I made some changes in this area in , since the support was primarily to do >> redirection from the cpumap prog, so by default we don't install anything now >> and only do so if a redirection interface is specified (and use devmap instead). >> So this option won't be used anyway going forward (since we don't install a >> dummy XDP_PASS program anymore) if it gets accepted. >> >> : https://firstname.lastname@example.org >> >> PS: I can restore it again if this is something really used beyond redirecting >> to another device (i.e. with custom BPF programs). Any feedback would be helpful. > > Hey Kartikeya. I happened to be looking through this code to get a > feel for using CPUMAP for custom steering (e.g. RSS on encapsulated > packets) in XDP and noticed the missing option character. Figured it > was worth doing a quick patch and test. > > Unfortunately, I'm not able to say much on your changes as I'm still > getting familiarized with this code. It looks like your submission is > in need of a rebase; v3 has been marked "Changes Requested" in > patchwork . As I see things, It'd be good to get this fix in there > for now, whether or not the code is removed later. Yeap, given this fix in here is tiny & valid either way, I took it in for now, and when Kartikeya's rework eventually drops the whole option, so be it. ;) Applied, thanks!
next prev parent reply other threads:[~2021-08-04 22:50 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-31 0:56 Matthew Cover 2021-07-31 15:25 ` Kumar Kartikeya Dwivedi 2021-08-04 17:57 ` Matt Cover 2021-08-04 22:50 ` Daniel Borkmann [this message] 2021-08-04 22:50 ` patchwork-bot+netdevbpf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH bpf-next] samples/bpf: xdp_redirect_cpu: Add mprog-disable to optstring.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).