From: David Howells <dhowells@redhat.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: Logically dead code at fs/afs/cell.c:206
Date: Fri, 17 Nov 2017 22:21:47 +0000
Message-ID: <4923.1510957307@warthog.procyon.org.uk> (raw)
In-Reply-To: <20171117215732.GA15974@embeddedor.com>
Gustavo A. R. Silva <garsilva@embeddedor.com> wrote:
> Today Coverity reported a "Logically dead code" issue at fs/afs/cell.c:206:
>
> if (!excl) {
> rcu_read_lock();
> cell = afs_lookup_cell_rcu(net, name, namesz);
> rcu_read_unlock();
> if (!IS_ERR(cell)) {
> if (excl) {
> afs_put_cell(net, cell);
> return ERR_PTR(-EEXIST);
> }
> goto wait_for_cell;
> }
> }
>
> The problem is that when this code block is executed, the code block
> starting at line 211 makes no sense, as _excl_ can never be true.
Good catch. The interior "if (excl) { ... }" statement and body needs
removing entirely. Originally the outer "if (!excl)" wrapping it wasn't
there.
David
next prev parent reply index
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 21:57 Gustavo A. R. Silva
2017-11-17 22:21 ` David Howells [this message]
2017-11-17 22:26 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4923.1510957307@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=garsilva@embeddedor.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
linux-kernel@vger.kernel.org
public-inbox-index lkml
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git