From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next 1/1] iomap: Fix a false positive of UBSAN in iomap_seek_data()
Date: Mon, 5 Jul 2021 11:35:08 +0800 [thread overview]
Message-ID: <492c7a7b-6f2e-de45-c733-51c80422305e@huawei.com> (raw)
In-Reply-To: <YN9vZfo+84gizjtf@casper.infradead.org>
On 2021/7/3 3:56, Matthew Wilcox wrote:
> On Fri, Jul 02, 2021 at 05:21:09PM +0800, Zhen Lei wrote:
>> Move the evaluation expression "size - offset" after the "if (offset < 0)"
>> judgment statement to eliminate a false positive produced by the UBSAN.
>>
>> No functional changes.
>>
>> ==========================================================================
>> UBSAN: Undefined behaviour in fs/iomap.c:1435:9
>> signed integer overflow:
>> 0 - -9223372036854775808 cannot be represented in type 'long long int'
>
> I don't understand. I thought we defined the behaviour of signed
> integer overflow in the kernel with whatever-the-gcc-flag-is?
-9223372036854775808 ==> 0x8000000000000000 ==> -0
I don't fully understand what you mean. This is triggered by explicit error
injection '-0' at runtime, which should not be detected by compilation options.
lseek(r1, 0x8000000000000000, 0x3)
>
>
> .
>
next prev parent reply other threads:[~2021-07-05 3:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 9:21 [PATCH -next 1/1] iomap: Fix a false positive of UBSAN in iomap_seek_data() Zhen Lei
2021-07-02 9:34 ` Christoph Hellwig
2021-07-02 11:50 ` Leizhen (ThunderTown)
2021-07-05 3:29 ` Leizhen (ThunderTown)
2021-07-05 3:43 ` Matthew Wilcox
2021-07-05 4:05 ` Leizhen (ThunderTown)
2021-07-04 13:51 ` Matthew Wilcox
2021-07-02 19:56 ` Matthew Wilcox
2021-07-05 3:35 ` Leizhen (ThunderTown) [this message]
2021-07-06 11:08 ` Matthew Wilcox
2021-07-06 11:59 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492c7a7b-6f2e-de45-c733-51c80422305e@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).