From: Guenter Roeck <linux@roeck-us.net>
To: Andrey Smirnov <andrew.smirnov@gmail.com>, linux-kernel@vger.kernel.org
Cc: linux-serial@vger.kernel.org, Rob Herring <robh@kernel.org>,
cphealy@gmail.com, Lucas Stach <l.stach@pengutronix.de>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Lee Jones <lee.jones@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pavel Machek <pavel@ucw.cz>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH v8 1/5] serdev: Make .remove in struct serdev_device_driver optional
Date: Sat, 21 Oct 2017 10:08:40 -0700 [thread overview]
Message-ID: <493297bf-245b-10be-2659-e9fa9f424f5e@roeck-us.net> (raw)
In-Reply-To: <20171018170136.12347-2-andrew.smirnov@gmail.com>
On 10/18/2017 10:01 AM, Andrey Smirnov wrote:
> Using devres infrastructure it is possible to wirte a serdev driver
s/wirte/write/
otherwise
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> that doesn't have any code that needs to be called as a part of
> .remove. Add code to make .remove optional.
>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-serial@vger.kernel.org
> Cc: Rob Herring <robh@kernel.org>
> Cc: cphealy@gmail.com
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Johan Hovold <johan@kernel.org>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> drivers/tty/serdev/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
> index c68fb3a8ea1c..f500f6a2ca88 100644
> --- a/drivers/tty/serdev/core.c
> +++ b/drivers/tty/serdev/core.c
> @@ -252,8 +252,8 @@ static int serdev_drv_probe(struct device *dev)
> static int serdev_drv_remove(struct device *dev)
> {
> const struct serdev_device_driver *sdrv = to_serdev_device_driver(dev->driver);
> -
> - sdrv->remove(to_serdev_device(dev));
> + if (sdrv->remove)
> + sdrv->remove(to_serdev_device(dev));
> return 0;
> }
>
>
next prev parent reply other threads:[~2017-10-21 17:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 17:01 [PATCH v8 0/5] ZII RAVE platform driver Andrey Smirnov
2017-10-18 17:01 ` [PATCH v8 1/5] serdev: Make .remove in struct serdev_device_driver optional Andrey Smirnov
2017-10-21 17:08 ` Guenter Roeck [this message]
2017-10-27 18:17 ` Sebastian Reichel
2017-10-18 17:01 ` [PATCH v8 2/5] serdev: Introduce devm_serdev_device_open() Andrey Smirnov
2017-10-21 17:09 ` Guenter Roeck
2017-10-28 9:48 ` Sebastian Reichel
2017-10-18 17:01 ` [PATCH v8 3/5] platform: Add driver for RAVE Supervisory Processor Andrey Smirnov
2017-10-21 17:17 ` Guenter Roeck
2017-10-23 17:07 ` Andrey Smirnov
2017-10-18 17:01 ` [PATCH v8 4/5] watchdog: Add RAVE SP watchdog driver Andrey Smirnov
2017-10-21 16:47 ` [v8,4/5] " Guenter Roeck
2017-10-21 23:34 ` Joe Perches
2017-10-23 17:01 ` Andrey Smirnov
2017-10-23 22:04 ` Guenter Roeck
2017-10-24 0:24 ` Andrey Smirnov
2017-10-18 17:01 ` [PATCH v8 5/5] dt-bindings: watchdog: Add bindings for " Andrey Smirnov
2017-10-24 19:07 ` Rob Herring
2017-10-25 15:00 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493297bf-245b-10be-2659-e9fa9f424f5e@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew.smirnov@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=cphealy@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).