From: Nishka Dasgupta <nishkadg.linux@gmail.com>
To: Roger Quadros <rogerq@ti.com>,
tony@atomide.com, linux-kernel@vger.kernel.org, "Kristo,
Tero" <t-kristo@ti.com>
Subject: Re: [PATCH] bus: ti-sysc: Remove if-block in sysc_check_children()
Date: Tue, 13 Aug 2019 12:42:55 +0530 [thread overview]
Message-ID: <4946dafe-f9c2-3cdf-fb0b-d08a32a20633@gmail.com> (raw)
In-Reply-To: <b1f8756e-4b15-7f1a-8562-5b80063733de@ti.com>
On 13/08/19 11:55 AM, Roger Quadros wrote:
>
>
> On 13/08/2019 07:35, Nishka Dasgupta wrote:
>> On 08/08/19 7:25 PM, Roger Quadros wrote:
>>> Nishka,
>>>
>>> On 08/08/2019 10:40, Nishka Dasgupta wrote:
>>>> In function sysc_check_children, there is an if-statement checking
>>>> whether the value returned by function sysc_check_one_child is non-zero.
>>>> However, sysc_check_one_child always returns 0, and hence this check is
>>>> not needed. Hence remove this if-block.
>>>>
>>>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>>>> ---
>>>> drivers/bus/ti-sysc.c | 2 --
>>>> 1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
>>>> index e6deabd8305d..bc8082ae7cb5 100644
>>>> --- a/drivers/bus/ti-sysc.c
>>>> +++ b/drivers/bus/ti-sysc.c
>>>> @@ -637,8 +637,6 @@ static int sysc_check_children(struct sysc *ddata)
>>>> for_each_child_of_node(ddata->dev->of_node, child) {
>>>> error = sysc_check_one_child(ddata, child);
>>>> - if (error)
>>>> - return error;
>>>
>>> We cannot assume that sysc_check_one_child() will never return error in the future.
>>> If it can never return an error then why does it have an int return type?
>>
>> I'm not sure why it has an int return type, unfortunately. This is the function in its entirety:
>>
>> static int sysc_check_one_child(struct sysc *ddata,
>> struct device_node *np)
>> {
>> const char *name;
>>
>> name = of_get_property(np, "ti,hwmods", NULL);
>> if (name)
>> dev_warn(ddata->dev, "really a child ti,hwmods property?");
>>
>> sysc_check_quirk_stdout(ddata, np);
>> sysc_parse_dts_quirks(ddata, np, true);
>>
>> return 0;
>> }
>>
>> I'm not sure how to understand this function. Do dev_warn() or sysc_check_quirk_stdout() or sysc_parse_dts_quirks() cause a non-zero return from sysc_check_one_child()? Should I drop my patch?
>
> None of those functions return anything.
> Maybe you can fix sysc_check_one_child() to return void?
> I think you can retain your patch but get rid of error variable.
Okay, I'll fixup and send v2. What about sysc_check_children()? If error
variable is removed then sysc_check_children also only returns 0.
Thanking you,
Nishka
>
>>
>> Thanking you,
>> Nishka
>>>
>>>> }
>>>> return 0;
>>>>
>>>
>
prev parent reply other threads:[~2019-08-13 7:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 7:40 [PATCH] bus: ti-sysc: Remove if-block in sysc_check_children() Nishka Dasgupta
2019-08-08 13:55 ` Roger Quadros
2019-08-13 4:35 ` Nishka Dasgupta
2019-08-13 6:25 ` Roger Quadros
2019-08-13 6:28 ` Tony Lindgren
2019-08-13 7:12 ` Nishka Dasgupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4946dafe-f9c2-3cdf-fb0b-d08a32a20633@gmail.com \
--to=nishkadg.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).