From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
<linux-mtd@lists.infradead.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
<linux-gpio@vger.kernel.org>, Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
<dmaengine@vger.kernel.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Wenyou Yang <wenyou.yang@atmel.com>,
Josh Wu <rainyfeeling@outlook.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
<linux-kernel@vger.kernel.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
<linux-arm-kernel@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH RESEND 4/5] mtd: nand: atmel: Document the new DT bindings
Date: Mon, 13 Feb 2017 18:31:02 +0100 [thread overview]
Message-ID: <494ca322-09c9-b782-8bb7-2eb3663779df@atmel.com> (raw)
In-Reply-To: <1485535324-28393-5-git-send-email-boris.brezillon@free-electrons.com>
Le 27/01/2017 à 17:42, Boris Brezillon a écrit :
> Document the new DT bindings for the Atmel NAND controller and
> deprecate the old ones.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Ok with the binding:
Reviewed-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> .../devicetree/bindings/mtd/atmel-nand.txt | 106 ++++++++++++++++++++-
> 1 file changed, 105 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/atmel-nand.txt b/Documentation/devicetree/bindings/mtd/atmel-nand.txt
> index 3e7ee99d3949..2a86ef2332dc 100644
> --- a/Documentation/devicetree/bindings/mtd/atmel-nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/atmel-nand.txt
> @@ -1,4 +1,108 @@
> -Atmel NAND flash
> +Atmel NAND flash controller bindings
> +
> +The NAND flash controller node should be defined under the EBI bus (see
> +Documentation/devicetree/bindings/memory-controllers/atmel,ebi.txt).
> +One or several NAND devices can be defined under this NAND controller.
> +The NAND controller might be connected to an ECC engine.
> +
> +* NAND controller bindings:
> +
> +Required properties:
> +- compatible: should be one of the following
> + "atmel,at91rm9200-nand-controller"
> + "atmel,at91sam9261-nand-controller"
> + "atmel,at91sam9g45-nand-controller"
> + "atmel,sama5d3-nand-controller"
> +- ranges: empty ranges property to forward EBI ranges definitions.
> +- #address-cells: should be set to 2.
> +- #size-cells: should be set to 1.
> +- atmel,nfc-io: phandle to the NFC IO block. Only required for sama5d3
> + controllers.
> +- atmel,nfc-sram: phandle to the NFC SRAM block. Only required for sama5d3
> + controllers.
> +
> +Optional properties:
> +- ecc-engine: phandle to the PMECC block. Only meaningful if the SoC embeds
> + a PMECC engine.
> +
> +* NAND device/chip bindings:
> +
> +Required properties:
> +- reg: describes the CS lines assigned to the NAND device. If the NAND device
> + exposes multiple CS lines (multi-dies chips), your reg property will
> + contain X tuples of 3 entries.
> + 1st entry: the CS line this NAND chip is connected to
> + 2nd entry: the base offset of the memory region assigned to this
> + device (always 0)
> + 3rd entry: the memory region size (always 0x800000)
> +
> +Optional properties:
> +- rb-gpios: the GPIO(s) used to check the Ready/Busy status of the NAND.
> +- cs-gpios: the GPIO(s) used to control the CS line.
> +- det-gpios: the GPIO used to detect if a Smartmedia Card is present.
> +- atmel,rb: an integer identifying the native Ready/Busy pin. Only meaningful
> + on sama5 SoCs.
> +
> +All generic properties described in
> +Documentation/devicetree/bindings/mtd/{common,nand}.txt also apply to the NAND
> +device node, and NAND partitions should be defined under the NAND node as
> +described in Documentation/devicetree/bindings/mtd/partition.txt.
> +
> +* ECC engine (PMECC) bindings:
> +
> +Required properties:
> +- compatible: should be one of the following
> + "atmel,at91sam9g45-pmecc"
> + "atmel,sama5d4-pmecc"
> + "atmel,sama5d2-pmecc"
> +- reg: should contain 2 register ranges. The first one is pointing to the PMECC
> + block, and the second one to the PMECC_ERRLOC block.
> +
> +Example:
> +
> + pmecc: ecc-engine@ffffc070 {
> + compatible = "atmel,at91sam9g45-pmecc";
> + reg = <0xffffc070 0x490>,
> + <0xffffc500 0x100>;
> + };
> +
> + ebi: ebi@10000000 {
> + compatible = "atmel,sama5d3-ebi";
> + #address-cells = <2>;
> + #size-cells = <1>;
> + atmel,smc = <&hsmc>;
> + reg = <0x10000000 0x10000000
> + 0x40000000 0x30000000>;
> + ranges = <0x0 0x0 0x10000000 0x10000000
> + 0x1 0x0 0x40000000 0x10000000
> + 0x2 0x0 0x50000000 0x10000000
> + 0x3 0x0 0x60000000 0x10000000>;
> + clocks = <&mck>;
> +
> + nand_controller: nand-controller {
> + compatible = "atmel,sama5d3-nand-controller";
> + atmel,nfc-sram = <&nfc_sram>;
> + atmel,nfc-io = <&nfc_io>;
> + ecc-engine = <&pmecc>;
> + #address-cells = <2>;
> + #size-cells = <1>;
> + ranges;
> +
> + nand@3 {
> + reg = <0x3 0x0 0x800000>;
> + atmel,rb = <0>;
> +
> + /*
> + * Put generic NAND/MTD properties and
> + * subnodes here.
> + */
> + };
> + };
> + };
> +
> +-----------------------------------------------------------------------
> +
> +Deprecated bindings (should not be used in new device trees):
>
> Required properties:
> - compatible: The possible values are:
>
--
Nicolas Ferre
next prev parent reply other threads:[~2017-02-13 17:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 16:41 [PATCH RESEND 0/5] mtd: nand: Rework/cleanup the Atmel NAND driver Boris Brezillon
2017-01-27 16:42 ` [PATCH RESEND 1/5] gpio: Add the devm_get_index_gpiod_from_child() helper Boris Brezillon
2017-01-27 16:42 ` [PATCH RESEND 2/5] dmaengine: Provide a wrapper for memcpy operations Boris Brezillon
2017-01-30 16:54 ` Vinod Koul
2017-01-30 17:47 ` Boris Brezillon
2017-01-31 3:34 ` Vinod Koul
2017-01-27 16:42 ` [PATCH RESEND 3/5] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon
2017-02-14 12:58 ` Nicolas Ferre
2017-02-14 13:27 ` Boris Brezillon
2017-01-27 16:42 ` [PATCH RESEND 4/5] mtd: nand: atmel: Document the new DT bindings Boris Brezillon
2017-02-01 15:39 ` Rob Herring
2017-02-01 15:47 ` Boris Brezillon
2017-02-10 12:55 ` Boris Brezillon
2017-02-10 13:58 ` Rob Herring
2017-02-10 14:00 ` Boris Brezillon
2017-02-13 17:31 ` Nicolas Ferre [this message]
2017-01-27 16:42 ` [PATCH RESEND 5/5] mtd: nand: Remove unused chip->write_page() hook Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494ca322-09c9-b782-8bb7-2eb3663779df@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=egtvedt@samfundet.no \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=hskinnemoen@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rainyfeeling@outlook.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vinod.koul@intel.com \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).