From: Rajendra Nayak <quic_rjendra@quicinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
"Krishna chaitanya chundru" <quic_krichai@quicinc.com>
Cc: <helgaas@kernel.org>, <linux-pci@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<mka@chromium.org>, <quic_vbadigan@quicinc.com>,
<quic_hemantk@quicinc.com>, <quic_nitegupt@quicinc.com>,
<quic_skananth@quicinc.com>, <quic_ramkri@quicinc.com>,
<swboyd@chromium.org>, <dmitry.baryshkov@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
"Andy Gross" <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v6 5/5] clk: qcom: Alwaya on pcie gdsc
Date: Tue, 13 Sep 2022 12:12:32 +0530 [thread overview]
Message-ID: <49536ca8-ef98-9927-d1be-977ab5244c91@quicinc.com> (raw)
In-Reply-To: <20220912170437.GA36223@thinkpad>
On 9/12/2022 10:34 PM, Manivannan Sadhasivam wrote:
> + Rajendra
>
> On Fri, Sep 09, 2022 at 02:14:44PM +0530, Krishna chaitanya chundru wrote:
>> Make GDSC always on to ensure controller and its dependent clocks
>> won't go down during system suspend.
>>
>
> You need to mention the SoC name in subject, otherwise one cannot know for
> which platform this patch applies to.
>
>> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
>> ---
>> drivers/clk/qcom/gcc-sc7280.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c
>> index 7ff64d4..2f781a2 100644
>> --- a/drivers/clk/qcom/gcc-sc7280.c
>> +++ b/drivers/clk/qcom/gcc-sc7280.c
>> @@ -3109,7 +3109,7 @@ static struct gdsc gcc_pcie_1_gdsc = {
>> .name = "gcc_pcie_1_gdsc",
>> },
>> .pwrsts = PWRSTS_OFF_ON,
>> - .flags = VOTABLE,
>> + .flags = ALWAYS_ON,
>
> Rajendra, should we also put PCIe GDSC into retention state as you have done for
> USB [1]?
Yes, it looks like we should handle this the same way as we did with usb.
Why are we removing the VOTABLE flag anyway?
>
> Thanks,
> Mani
>
> [1] https://lore.kernel.org/all/20220901101756.28164-2-quic_rjendra@quicinc.com/
>
>> };
>>
>> static struct gdsc gcc_ufs_phy_gdsc = {
>> --
>> 2.7.4
>>
>
next prev parent reply other threads:[~2022-09-13 6:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 8:44 [PATCH v6 0/5] PCI: qcom: Add system suspend & resume support Krishna chaitanya chundru
2022-09-09 8:44 ` [PATCH v6 1/5] PCI: qcom: Add system suspend and " Krishna chaitanya chundru
2022-09-09 17:31 ` Matthias Kaehlcke
2022-09-12 16:06 ` Krishna Chaitanya Chundru
2022-09-12 16:54 ` Matthias Kaehlcke
2022-09-12 17:09 ` Manivannan Sadhasivam
2022-09-09 8:44 ` [PATCH v6 2/5] PCI: qcom: Add retry logic for link to be stable in L1ss Krishna chaitanya chundru
2022-09-09 19:50 ` Bjorn Helgaas
2022-09-12 16:09 ` Krishna Chaitanya Chundru
2022-09-12 17:33 ` Manivannan Sadhasivam
2022-09-13 14:24 ` Krishna Chaitanya Chundru
2022-09-13 16:39 ` Manivannan Sadhasivam
2022-09-14 1:45 ` Krishna Chaitanya Chundru
2022-09-14 5:59 ` Manivannan Sadhasivam
2022-09-19 16:23 ` kernel test robot
2022-09-09 8:44 ` [PATCH v6 3/5] phy: core: Add support for phy power down & power up Krishna chaitanya chundru
2022-09-09 9:04 ` Dmitry Baryshkov
2022-09-14 14:50 ` Krishna Chaitanya Chundru
2022-09-19 17:29 ` Dmitry Baryshkov
2022-09-20 9:41 ` Krishna Chaitanya Chundru
2022-09-13 14:58 ` Vinod Koul
2022-09-13 16:41 ` Bjorn Helgaas
2022-09-09 8:44 ` [PATCH v6 4/5] phy: qcom: Add power down/up callbacks to pcie phy Krishna chaitanya chundru
2022-09-09 8:44 ` [PATCH v6 5/5] clk: qcom: Alwaya on pcie gdsc Krishna chaitanya chundru
2022-09-12 17:04 ` Manivannan Sadhasivam
2022-09-13 6:42 ` Rajendra Nayak [this message]
2022-09-13 16:42 ` Manivannan Sadhasivam
2022-09-14 1:47 ` Krishna Chaitanya Chundru
2022-09-13 16:34 ` Bjorn Helgaas
2022-09-14 1:48 ` Krishna Chaitanya Chundru
2022-09-09 19:51 ` [PATCH v6 0/5] PCI: qcom: Add system suspend & resume support Bjorn Helgaas
2022-09-12 16:10 ` Krishna Chaitanya Chundru
2022-09-12 17:08 ` Bjorn Helgaas
2022-09-12 17:21 ` Manivannan Sadhasivam
2022-09-12 17:37 ` Manivannan Sadhasivam
2022-09-14 1:47 ` Krishna Chaitanya Chundru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49536ca8-ef98-9927-d1be-977ab5244c91@quicinc.com \
--to=quic_rjendra@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=helgaas@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=quic_hemantk@quicinc.com \
--cc=quic_krichai@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=sboyd@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).