From: Marcel Holtmann <marcel@holtmann.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Johan Hedberg <johan.hedberg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Douglas Anderson <dianders@chromium.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-rockchip@lists.infradead.org,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Rajat Jain <rajatja@google.com>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v2 1/3] Bluetooth: btusb: add QCA6174A compatible properties
Date: Tue, 26 Feb 2019 10:01:34 +0100 [thread overview]
Message-ID: <49653AC5-5800-4319-B3C0-0CCA6A920E2C@holtmann.org> (raw)
In-Reply-To: <20190222225345.69084-1-briannorris@chromium.org>
Hi Brian,
> We may need to specify a GPIO wake pin for this device, so add a
> compatible property for it.
>
> There are at least to USB PID/VID variations of this chip: one with a
> Lite-On ID and one with an Atheros ID.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> v2:
> * drop leading zeroes from VID, per documented binding
> ---
> drivers/bluetooth/btusb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 470ee68555d9..54cb5f583b1d 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -2862,6 +2862,8 @@ static irqreturn_t btusb_oob_wake_handler(int irq, void *priv)
>
> static const struct of_device_id btusb_match_table[] = {
> { .compatible = "usb1286,204e" },
> + { .compatible = "usbcf3,e300" }, /* QCA6174A */
> + { .compatible = "usb4ca,301a" }, /* QCA6174A (Lite-On) */
are these really proper .compatible USB VID?PID strings. I think they are one letter short.
Regards
Marcel
next prev parent reply other threads:[~2019-02-26 9:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 22:53 [PATCH v2 1/3] Bluetooth: btusb: add QCA6174A compatible properties Brian Norris
2019-02-22 22:53 ` [PATCH v2 2/3] dt-bindings: net: btusb: add QCA6174A IDs Brian Norris
2019-02-26 22:32 ` Rob Herring
2019-02-22 22:53 ` [PATCH v2 3/3] arm64: dts: rockchip: move QCA6174A wakeup pin into its USB node Brian Norris
2019-02-26 9:01 ` Marcel Holtmann [this message]
2019-02-26 13:31 ` [PATCH v2 1/3] Bluetooth: btusb: add QCA6174A compatible properties Robin Murphy
2019-02-27 7:53 ` Marcel Holtmann
2019-02-27 21:34 ` Brian Norris
2019-03-26 18:45 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49653AC5-5800-4319-B3C0-0CCA6A920E2C@holtmann.org \
--to=marcel@holtmann.org \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=heiko@sntech.de \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mka@chromium.org \
--cc=rajatja@google.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).