From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF22C41535 for ; Wed, 15 Aug 2018 18:21:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F205221528 for ; Wed, 15 Aug 2018 18:21:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="lfFptszD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F205221528 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728036AbeHOVNP (ORCPT ); Wed, 15 Aug 2018 17:13:15 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:50974 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726056AbeHOVNP (ORCPT ); Wed, 15 Aug 2018 17:13:15 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id w7FIJw5H005765; Wed, 15 Aug 2018 13:19:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1534357198; bh=iTzswvn5tSTeBq/nrRrgIfuDg5v3GV/GXx5QcAQigXc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=lfFptszDlKiMOX2yEHOBDB1AgIqh/KXIDOVK7I0cbotkYJey8FjltZFcOQ40Mzqu9 4DTDj6NzIXMjZWRZS84BtDuZGeTdnFRJ3D1N7vVNL5HkaiCAS12CJBIXQ3eX/z3Kr/ Iuwvt+xYOivTMKlH2ZE2MVixXitzEaim2SCWpe8U= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w7FIJvJZ026646; Wed, 15 Aug 2018 13:19:57 -0500 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 15 Aug 2018 13:19:57 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Wed, 15 Aug 2018 13:19:57 -0500 Received: from [172.22.176.241] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w7FIJup3013292; Wed, 15 Aug 2018 13:19:56 -0500 Subject: Re: [PATCH v3 1/2] dt-bindings: leds: Add bindings for lm3697 driver To: Jacek Anaszewski , , CC: , , References: <20180815161734.18159-1-dmurphy@ti.com> <77f11321-8876-2e34-f05e-dd855d62095c@gmail.com> From: Dan Murphy Message-ID: <4974c577-9c40-1f30-deac-47167d1afd03@ti.com> Date: Wed, 15 Aug 2018 13:19:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <77f11321-8876-2e34-f05e-dd855d62095c@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jacek On 08/15/2018 01:09 PM, Jacek Anaszewski wrote: > Dan, > > On 08/15/2018 07:30 PM, Dan Murphy wrote: >> Jacek >> >> On 08/15/2018 11:56 AM, Jacek Anaszewski wrote: >>> Hi Dan, >>> >>> Thank you for the update. >>> >>> On 08/15/2018 06:17 PM, Dan Murphy wrote: >>>> Add the device tree bindings for the lm3697 >>>> LED driver for backlighting and display. >>>> >>>> Signed-off-by: Dan Murphy >>>> --- >>>> >>>> v3 - Updated subject with prefered title - https://lore.kernel.org/patchwork/patch/972337/ >>>> v2 - Fixed subject and patch commit message - https://lore.kernel.org/patchwork/patch/971326/ >>>> >>>> .../devicetree/bindings/leds/leds-lm3697.txt | 89 +++++++++++++++++++ >>>> 1 file changed, 89 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3697.txt b/Documentation/devicetree/bindings/leds/leds-lm3697.txt >>>> new file mode 100644 >>>> index 000000000000..34403a48a0ce >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/leds/leds-lm3697.txt >>>> @@ -0,0 +1,89 @@ >>>> +* Texas Instruments - LM3697 Highly Efficient White LED Driver >>>> + >>>> +The LM3697 11-bit LED driver provides high- >>>> +performance backlight dimming for 1, 2, or 3 series >>>> +LED strings while delivering up to 90% efficiency. >>>> + >>>> +This device is suitable for Display and Keypad Lighting >>>> + >>>> +Required properties: >>>> + - compatible: >>>> + "ti,lm3967" >>>> + - reg : I2C slave address >>>> + - #address-cells : 1 >>>> + - #size-cells : 0 >>>> + >>>> +Optional properties: >>>> + - enable-gpios : gpio pin to enable/disable the device. >>>> + - vled-supply : LED supply >>>> + >>>> +Required child properties: >>>> + - reg : 0 - LED is Controlled by bank A >>>> + 1 - LED is Controlled by bank B >>>> + - led-sources - Indicates which HVLED string is associated to which >>>> + control bank. The HVLED string cannot be associated with >>>> + two control banks. This property is an array of 3 and >>>> + all positions in the array must be populated. >>>> + Additional information is contained >>>> + in Documentation/devicetree/bindings/leds/common.txt >>>> + 0 - End of array if all 3 LEDs are not declared for a >>>> + single control bank. >>> >>> This is needless complication. I propose to define led-sources as >>> an array of three boolean values, whose state signifies which LED >>> strings are controlled by the bank defined by the reg property in the >>> given child node. I.e. . >> >> I struggled a bit with this definition. Once I got it working it ended up producing >> an overly complex control bank algorithm. >> >> I will take a look at implementing the suggestion but the complication comes in the >> numerous DT configurations we could encounter. Part of the issue is that the user >> can connect to CTRL bank b only or CTRL bank a only or a combination of that >> >> 2^3 > > I tried to play a bit with that and here is what I got (simplified > DT parsing): > Thanks for the attempt. I think with my current code patch I might be able to get this to work. As per your suggestion. It just takes a while to test all the combos Dan > int used_hvleds[3] = {0, 0 ,0}; > int used_control_banks[2] = {0, 0}; > > int parse_child_node(struct fwnode_handle *child) > { > int bank_hvleds[3]; > > fwnode_property_read_u32_array(child, "led-sources", > bank_hvleds, LM3697_MAX_LED_STRINGS); > > for (i = 0; i <= 3; i++) { > if (bank_hvleds[i] && used_hvleds[i]) > return -EINVAL; > used_hvleds[i] = 1; > } > > return 0; > } > > struct fwnode_handle *child = NULL; > > device_for_each_child_node(priv->dev, child) > fwnode_property_read_u32(child, "reg", &control_bank); > if (used_control_banks[control_bank]) > goto err; > used_control_banks[control_bank] = 1; > if (parse_child_node(child)) > goto err; > > >>> >>> I modified your examples below accordingly. >>> >>>> + 1 - HVLED 1 string >>>> + 2 - HVLED 2 string >>>> + 3 - HVLED 3 string >>>> + >>>> +Optional child properties: >>>> + - label : see Documentation/devicetree/bindings/leds/common.txt >>>> + - linux,default-trigger : >>>> + see Documentation/devicetree/bindings/leds/common.txt >>>> + >>>> +Example: >>>> + >>>> +HVLED string 1 and 2 controlled by control bank A and HVLED string controlled by >>>> +control bank B. >>>> + >>>> +led-controller@36 { >>>> + compatible = "ti,lm3967"; >>>> + reg = <0x36>; >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + >>>> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; >>>> + vled-supply = <&vbatt>; >>>> + >>>> + led@0 { >>>> + reg = <0>; >>>> + led-sources = <0x1 0x2 0x0> >>> >>> led-sources = <1 1 0>; >>> ; >>>> + label = "white:first_backlight_cluster"; >>>> + linux,default-trigger = "backlight"; >>>> + }; >>>> + >>>> + led@1 { >>>> + reg = <1>; >>>> + led-sources = <0x3 0x0 0x0>; >>> >>> led-sources = <0 0 1>; >>> >>>> + label = "white:second_backlight_cluster"; >>>> + linux,default-trigger = "backlight"; >>>> + }; >>>> +} >>>> + >>>> +All HVLED strings controlled by control bank A >>>> + >>>> +led-controller@36 { >>>> + compatible = "ti,lm3967"; >>>> + reg = <0x36>; >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + >>>> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; >>>> + vled-supply = <&vbatt>; >>>> + >>>> + led@0 { >>>> + reg = <0>; >>>> + led-sources = <0x1 0x2 0x3>; >>> >>> led-sources = <1 1 1>; >>> >>>> + label = "white:backlight_cluster"; >>>> + linux,default-trigger = "backlight"; >>>> + }; >>>> +} >>>> + >>>> +For more product information please see the link below: >>>> +http://www.ti.com/lit/ds/symlink/lm3697.pdf >>>> >>> >> >> > -- ------------------ Dan Murphy