From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161312Ab2JXWFA (ORCPT ); Wed, 24 Oct 2012 18:05:00 -0400 Received: from ogre.sisk.pl ([193.178.161.156]:35697 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161189Ab2JXWE4 (ORCPT ); Wed, 24 Oct 2012 18:04:56 -0400 From: "Rafael J. Wysocki" To: Toshi Kani Cc: Yasuaki Ishimatsu , linux-acpi@vger.kernel.org, lenb@kernel.org, linux-kernel@vger.kernel.org, liuj97@gmail.com Subject: Re: [PATCH 2/2] ACPI: Remove unused lockable in acpi_device_flags Date: Thu, 25 Oct 2012 00:08:52 +0200 Message-ID: <4977274.iWiO0dh4FZ@vostro.rjw.lan> User-Agent: KMail/4.8.5 (Linux/3.6.2-6-desktop; KDE/4.8.5; x86_64; ; ) In-Reply-To: <1350482209.28185.2.camel@misato.fc.hp.com> References: <1350318870-5700-1-git-send-email-toshi.kani@hp.com> <507E0942.1080708@jp.fujitsu.com> <1350482209.28185.2.camel@misato.fc.hp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 17 of October 2012 07:56:49 Toshi Kani wrote: > On Wed, 2012-10-17 at 10:26 +0900, Yasuaki Ishimatsu wrote: > > 2012/10/16 1:34, Toshi Kani wrote: > > > Removed lockable in struct acpi_device_flags since it is no > > > longer used by any code. acpi_bus_hot_remove_device() cannot > > > use this flag because acpi_bus_trim() frees up its acpi_device > > > object. Furthermore, the dock driver calls _LCK method without > > > using this lockable flag. > > > > > > Signed-off-by: Toshi Kani > > > > Looks good to me. > > Reviewed-by: Yasuaki Ishimatsu > > Thanks Yasuaki for reviewing! Applied to linux-pm.git/acpi-next as v3.8 material. Thanks, Rafael > > > --- > > > drivers/acpi/scan.c | 5 ----- > > > include/acpi/acpi_bus.h | 3 +-- > > > 2 files changed, 1 insertion(+), 7 deletions(-) > > > > > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > > > index ed87f43..19d3d4a 100644 > > > --- a/drivers/acpi/scan.c > > > +++ b/drivers/acpi/scan.c > > > @@ -1017,11 +1017,6 @@ static int acpi_bus_get_flags(struct acpi_device *device) > > > device->flags.ejectable = 1; > > > } > > > > > > - /* Presence of _LCK indicates 'lockable' */ > > > - status = acpi_get_handle(device->handle, "_LCK", &temp); > > > - if (ACPI_SUCCESS(status)) > > > - device->flags.lockable = 1; > > > - > > > /* Power resources cannot be power manageable. */ > > > if (device->device_type == ACPI_BUS_TYPE_POWER) > > > return 0; > > > diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h > > > index 0daa0fb..e8b2877 100644 > > > --- a/include/acpi/acpi_bus.h > > > +++ b/include/acpi/acpi_bus.h > > > @@ -144,12 +144,11 @@ struct acpi_device_flags { > > > u32 bus_address:1; > > > u32 removable:1; > > > u32 ejectable:1; > > > - u32 lockable:1; > > > u32 suprise_removal_ok:1; > > > u32 power_manageable:1; > > > u32 performance_manageable:1; > > > u32 eject_pending:1; > > > - u32 reserved:23; > > > + u32 reserved:24; > > > }; > > > > > > /* File System */ > > > > > > > > > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.