From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Greg KH <greg@kroah.com>
Cc: Pavel Machek <pavel@suse.cz>,
Sandro Bonazzola <sandro.bonazzola@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] w35und: fix usb_control_msg() error handling in wb35_probe()
Date: Mon, 26 Jan 2009 20:03:48 +0200 [thread overview]
Message-ID: <497DFB04.1040802@cs.helsinki.fi> (raw)
In-Reply-To: <20090126175115.GA29205@kroah.com>
Greg KH wrote:
> On Thu, Jan 22, 2009 at 12:06:33PM +0200, Pekka J Enberg wrote:
>> From: Pekka Enberg <penberg@cs.helsinki.fi>
>>
>> If successful, the usb_control_msg() function returns the number of
>> bytes transferred. Fix up wb35_probe() to only bail out if the function
>> returns a negative number.
>>
>> Reported-by: Sandro Bonazzola <sandro.bonazzola@gmail.com>
>> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
>
> I'm confused, should I apply this patch or not?
Yes, you should. What's confusing you here?
Pekka
next prev parent reply other threads:[~2009-01-26 18:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 10:06 [PATCH] w35und: fix usb_control_msg() error handling in wb35_probe() Pekka J Enberg
2009-01-22 11:42 ` Pavel Machek
2009-01-22 19:25 ` Sandro Bonazzola
2009-01-22 21:10 ` Pavel Machek
2009-01-22 21:19 ` Harvey Harrison
2009-01-22 22:32 ` Pekka Enberg
2009-01-22 22:34 ` Sandro Bonazzola
2009-01-22 22:31 ` Pekka Enberg
2009-01-26 19:31 ` Sandro Bonazzola
2009-01-26 19:40 ` Pekka Enberg
2009-01-26 19:43 ` Pekka Enberg
2009-01-26 20:13 ` Sandro Bonazzola
2009-01-26 20:22 ` Pekka Enberg
2009-01-26 21:42 ` Pavel Machek
2009-01-22 22:37 ` Pekka Enberg
2009-01-26 17:51 ` Greg KH
2009-01-26 18:03 ` Pekka Enberg [this message]
2009-01-26 18:10 ` Pekka Enberg
2009-01-29 19:24 ` Greg KH
2009-01-30 9:32 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497DFB04.1040802@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=sandro.bonazzola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).