From: Ben Greear <greearb@candelatech.com>
To: Len Brown <lenb@kernel.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
NetDev <netdev@vger.kernel.org>,
linux-acpi@vger.kernel.org
Subject: Re: Regression on VIA C3 motherboard, commit: 66f2173e2
Date: Fri, 06 Feb 2009 11:52:58 -0800 [thread overview]
Message-ID: <498C951A.3070101@candelatech.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0902061350470.26256@localhost.localdomain>
Len Brown wrote:
> Thanks for the bisect, Ben.
>
> Please test the patch below.
With this patch, performance is fine, and I do not see
my smp hack being exercised. I still have ACPI off
in the BIOS, and on in the kernel (ie, no change
from the original test case).
So, this very well could be the fix.
Thanks,
Ben
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index 775c97a..a885295 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -293,7 +293,12 @@ static void __init check_multiple_madt(void)
>
> int __init acpi_table_init(void)
> {
> - acpi_initialize_tables(initial_tables, ACPI_MAX_TABLES, 0);
> + acpi_status status;
> +
> + status = acpi_initialize_tables(initial_tables, ACPI_MAX_TABLES, 0);
> + if (ACPI_FAILURE(status))
> + return 1;
> +
> check_multiple_madt();
> return 0;
> }
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2009-02-06 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 7:23 Regression on VIA C3 motherboard, commit: 66f2173e2 Ben Greear
2009-02-06 0:33 ` Robert Hancock
2009-02-06 6:10 ` Ben Greear
2009-02-06 14:46 ` Robert Hancock
2009-02-06 18:57 ` Len Brown
2009-02-06 19:20 ` Ben Greear
2009-02-06 19:52 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498C951A.3070101@candelatech.com \
--to=greearb@candelatech.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).