From: Shuah Khan <email@example.com> To: Alexei Starovoitov <firstname.lastname@example.org> Cc: Shuah Khan <email@example.com>, Daniel Borkmann <firstname.lastname@example.org>, Thomas Meyer <email@example.com>, firstname.lastname@example.org, email@example.com, Networking <firstname.lastname@example.org>, Shuah Khan <email@example.com> Subject: Re: selftests/bpf doesn't compile Date: Fri, 15 Sep 2017 16:32:45 -0600 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20170915181440.adkgyqbt4yxrnbw7@ast-mbp> On 09/15/2017 12:14 PM, Alexei Starovoitov wrote: > On Fri, Sep 15, 2017 at 11:00:31AM -0600, Shuah Khan wrote: >>>> I could add a special target for bpf TARGET_BPF perhaps and exclude it from >>>> the run_test> >>> I'm not sure what was the motivation to exclude hotplug from default testing, >> >> These are considered a bit more disruptive and were excluded a while >> back. These take cpus and memory on and off-line. Also require >> root access. So even if they are included in the regular run, these >> won't run. > > most of bpf tests require root access as well. > >> The first failure due to clang dependency is not a problem. The second one >> in the case of "make kselftest" is the one that requires some work when bpf >> make is run from the main Makefile. A lots of users run tests using the >> kselftest target from the mail Makefile. hence I would like to get this >> working, so it would be easier to run this test on test servers. > > 'make kselftest' doesn't work for me at all, since I suspect it > assumes in-source build. I always use KBUILD_OUTPUT, > since I build multiple archs with different configs out of the same > source tree, so there is a bigger problem here. Right. I think you probably use make KBUILD_OUTPUT=dir -C tools/testing/selftests/bpf > > $ make kselftest > make: Entering directory `/data/users/ast/net-next/bld_x64' > make: Entering an unknown directory > make: *** tools/testing/selftests: No such file or directory. Stop. > make: Leaving an unknown directory > make: *** [kselftest] Error 2 > make: Leaving directory `/data/users/ast/net-next/bld_x64' > make: *** [sub-make] Error 2 > Right. There is patch set out to fix this problem which I sent out couple of days ago. It is probably the case that bpf Makefile might need changes to build when it is built from the sleftests/Makefile or the main Makefile. thanks, -- Shuah
next prev parent reply other threads:[~2017-09-15 22:32 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-08 11:19 [PATCH] selftests/bpf: Make bpf_util work on uniprocessor systems Thomas Meyer 2017-09-08 23:01 ` Alexei Starovoitov 2017-09-08 23:05 ` Daniel Borkmann 2017-09-14 15:01 ` Shuah Khan 2017-09-14 15:33 ` selftests/bpf doesn't compile Shuah Khan 2017-09-15 16:02 ` Alexei Starovoitov 2017-09-15 16:58 ` Edward Cree 2017-09-15 18:07 ` Alexei Starovoitov 2017-09-15 18:23 ` Daniel Borkmann 2017-09-15 18:48 ` Daniel Borkmann 2017-09-15 22:41 ` Shuah Khan 2017-09-18 13:31 ` Daniel Borkmann 2017-09-15 17:00 ` Shuah Khan 2017-09-15 17:44 ` Shuah Khan 2017-09-15 18:14 ` Alexei Starovoitov 2017-09-15 22:32 ` Shuah Khan [this message] 2019-01-04 17:16 ` Geert Uytterhoeven 2019-01-04 19:07 ` shuah 2017-09-19 14:45 ` [PATCH] selftests/bpf: Make bpf_util work on uniprocessor systems Shuah Khan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: selftests/bpf doesn'\''t compile' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).