From: etienne <etienne.basset@numericable.fr>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
Dave Airlie <airlied@linux.ie>, Dave Airlie <airlied@redhat.com>,
Soeren Sonnenburg <kernel@nn7.de>
Subject: Re: [Bug #12613] [Suspend regression][DRM, RADEON]
Date: Sun, 15 Feb 2009 11:20:07 +0100 [thread overview]
Message-ID: <4997EC57.1020608@numericable.fr> (raw)
In-Reply-To: <4997E7D7.60205@numericable.fr>
etienne wrote:
> Rafael J. Wysocki wrote:
>> This message has been generated automatically as a part of a report
>> of recent regressions.
>>
>> The following bug entry is on the current list of known regressions
>> from 2.6.28. Please verify if it still should be listed and let me know
>> (either way).
>>
>>
>> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12613
>> Subject : [Suspend regression][DRM, RADEON]
>> Submitter : etienne <etienne.basset@numericable.fr>
>> Date : 2009-01-28 22:00 (18 days old)
>> First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a9d51a5ad1154b5b20add1e8d30a5564f8aabbe9
>> References : http://marc.info/?l=linux-kernel&m=123318030419558&w=4
>> http://marc.info/?l=linux-kernel&m=123334865404574&w=4
>> http://lkml.org/lkml/2009/2/8/203
>>
>>
>>
hello,
yes it is still present in -rc5;
the following unreviewed patch fixes it for me;
regards,
Etienne, who should learn to send correct emails
Signed-off-by: <etienne.basset@numericable.fr>
---
diff --git a/drivers/gpu/drm/radeon/radeon_cp.c b/drivers/gpu/drm/radeon/radeon_cp.c
index df4cf97..6554adf 100644
--- a/drivers/gpu/drm/radeon/radeon_cp.c
+++ b/drivers/gpu/drm/radeon/radeon_cp.c
@@ -557,7 +557,8 @@ static int radeon_do_engine_reset(struct drm_device * dev)
}
static void radeon_cp_init_ring_buffer(struct drm_device * dev,
- drm_radeon_private_t * dev_priv)
+ drm_radeon_private_t * dev_priv,
+ struct drm_radeon_master_private *master)
{
u32 ring_start, cur_read_ptr;
u32 tmp;
@@ -668,13 +669,13 @@ static void radeon_cp_init_ring_buffer(struct drm_device * dev,
RADEON_WRITE(RADEON_BUS_CNTL, tmp);
} /* PCIE cards appears to not need this */
- dev_priv->scratch[0] = 0;
+ master->sarea_priv->last_frame = dev_priv->scratch[0] = 0;
RADEON_WRITE(RADEON_LAST_FRAME_REG, 0);
- dev_priv->scratch[1] = 0;
+ master->sarea_priv->last_dispatch = dev_priv->scratch[1] = 0;
RADEON_WRITE(RADEON_LAST_DISPATCH_REG, 0);
- dev_priv->scratch[2] = 0;
+ master->sarea_priv->last_clear = dev_priv->scratch[2] = 0;
RADEON_WRITE(RADEON_LAST_CLEAR_REG, 0);
radeon_do_wait_for_idle(dev_priv);
@@ -1215,7 +1216,7 @@ static int radeon_do_init_cp(struct drm_device *dev, drm_radeon_init_t *init,
}
radeon_cp_load_microcode(dev_priv);
- radeon_cp_init_ring_buffer(dev, dev_priv);
+ radeon_cp_init_ring_buffer(dev, dev_priv, master_priv);
dev_priv->last_buf = 0;
@@ -1281,9 +1282,11 @@ static int radeon_do_cleanup_cp(struct drm_device * dev)
*
* Charl P. Botha <http://cpbotha.net>
*/
-static int radeon_do_resume_cp(struct drm_device * dev)
+static int radeon_do_resume_cp(struct drm_device * dev,
+ struct drm_file * file_priv)
{
drm_radeon_private_t *dev_priv = dev->dev_private;
+ struct drm_radeon_master_private * master_priv = file_priv->master->driver_priv;
if (!dev_priv) {
DRM_ERROR("Called with no initialization\n");
@@ -1304,7 +1307,7 @@ static int radeon_do_resume_cp(struct drm_device * dev)
}
radeon_cp_load_microcode(dev_priv);
- radeon_cp_init_ring_buffer(dev, dev_priv);
+ radeon_cp_init_ring_buffer(dev, dev_priv, master_priv);
radeon_do_engine_reset(dev);
radeon_irq_set_state(dev, RADEON_SW_INT_ENABLE, 1);
@@ -1480,7 +1483,7 @@ int radeon_cp_idle(struct drm_device *dev, void *data, struct drm_file *file_pri
int radeon_cp_resume(struct drm_device *dev, void *data, struct drm_file *file_priv)
{
- return radeon_do_resume_cp(dev);
+ return radeon_do_resume_cp(dev, file_priv);
}
int radeon_engine_reset(struct drm_device *dev, void *data, struct drm_file *file_priv)
next prev parent reply other threads:[~2009-02-15 10:20 UTC|newest]
Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 20:35 2.6.29-rc5: Reported regressions from 2.6.28 Rafael J. Wysocki
2009-02-14 20:35 ` [Bug #12414] iwl4965 cannot use "ap auto" on latest 2.6.28/29? Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12444] X hangs following switch from radeonfb console - Bisected Rafael J. Wysocki
2009-02-16 17:52 ` Graham Murray
2009-02-16 21:52 ` Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12418] Repeated ioctl(4, 0x40046445, ..) loop in glxgears Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12490] ath5k related kernel panic in 2.6.29-rc1 Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12419] possible circular locking dependency on i915 dma Rafael J. Wysocki
2009-02-16 3:50 ` Wang Chen
2009-02-14 20:38 ` [Bug #12497] new barrier warnings in 2.6.29-rc1 Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12496] swsusp cannot find resume device (sometimes) Rafael J. Wysocki
2009-02-15 0:05 ` Arjan van de Ven
2009-02-15 14:23 ` Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12491] i915 lockdep warning Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12494] Sony backlight regression from 2.6.28 to 29-rc Rafael J. Wysocki
2009-02-17 10:51 ` Norbert Preining
2009-02-14 20:38 ` [Bug #12499] Problem with using bluetooth adaper connected to usb port Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12501] build bug in eeepc-laptop.c Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12502] pipe_read oops on sh Rafael J. Wysocki
2009-02-15 0:23 ` Adrian McMenamin
2009-02-15 14:27 ` Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12510] 2.6.29-rc2 dies on startup Rafael J. Wysocki
2009-02-16 21:02 ` Ferenc Wagner
2009-02-16 21:12 ` Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12551] end_request: I/O error, dev cciss/c0d0, sector 87435720 Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12610] sync-Regression in 2.6.28.2? Rafael J. Wysocki
2009-02-21 17:56 ` Theodore Tso
2009-02-22 10:02 ` Rafael J. Wysocki
2009-02-23 4:35 ` Greg KH
2009-02-23 5:37 ` Theodore Tso
2009-02-23 16:54 ` [stable] " Greg KH
2009-02-14 20:38 ` [Bug #12609] v2.6.29-rc2 libata sff 32bit PIO regression Rafael J. Wysocki
2009-02-15 4:20 ` Larry Finger
2009-02-15 8:10 ` Jeff Garzik
2009-02-15 12:05 ` Sergei Shtylyov
2009-02-15 16:48 ` Hugh Dickins
2009-02-14 20:38 ` [Bug #12574] possible circular locking dependency detected Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12571] Suspend-resume on Dell Latitude D410 newly broken in 2.6.29-rc* Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12615] boot hangs while bringing up gianfar ethernet Rafael J. Wysocki
2009-02-15 14:42 ` Peter Korsgaard
2009-02-15 21:08 ` Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12613] [Suspend regression][DRM, RADEON] Rafael J. Wysocki
[not found] ` <4997E7D7.60205@numericable.fr>
2009-02-15 10:20 ` etienne [this message]
2009-02-14 20:38 ` [Bug #12659] Failure to resume two Sandisk USB flash drives attached to a Belkin USB Busport Mobile (F5U022) Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12617] unable to compile e100 firmware into kernel Rafael J. Wysocki
2009-02-15 17:38 ` David Woodhouse
2009-02-15 19:58 ` Andrey Borzenkov
2009-02-15 21:09 ` Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12618] hackbench [pthread mode] regression with 2.6.29-rc3 Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12650] Strange load average and ksoftirqd behavior with 2.6.29-rc2-git1 Rafael J. Wysocki
2009-02-15 8:09 ` Damien Wyart
2009-02-15 9:00 ` Ingo Molnar
2009-02-15 9:51 ` Damien Wyart
2009-02-15 10:13 ` Ingo Molnar
2009-02-15 10:34 ` Damien Wyart
2009-02-15 10:41 ` Damien Wyart
2009-02-15 10:42 ` Damien Wyart
2009-02-15 10:43 ` Damien Wyart
2009-02-15 11:01 ` Ingo Molnar
2009-02-15 14:06 ` Frederic Weisbecker
2009-02-15 18:03 ` Damien Wyart
2009-02-15 19:18 ` Damien Wyart
2009-02-15 19:31 ` Ingo Molnar
2009-02-16 8:42 ` Damien Wyart
2009-02-16 9:21 ` Ingo Molnar
2009-02-16 10:49 ` Damien Wyart
2009-02-16 9:25 ` Ingo Molnar
2009-02-16 9:27 ` Ingo Molnar
2009-02-16 9:32 ` Ingo Molnar
2009-02-16 9:50 ` Ingo Molnar
2009-02-16 11:56 ` Damien Wyart
2009-02-16 12:26 ` Ingo Molnar
2009-02-16 13:02 ` Damien Wyart
2009-02-16 13:21 ` Ingo Molnar
2009-02-16 16:06 ` Paul E. McKenney
2009-02-16 18:56 ` Paul E. McKenney
2009-02-16 19:08 ` Frederic Weisbecker
2009-02-16 20:02 ` Frederic Weisbecker
2009-02-16 21:31 ` Paul E. McKenney
2009-02-16 20:09 ` Ingo Molnar
2009-02-16 22:39 ` Paul E. McKenney
2009-02-16 22:51 ` Paul E. McKenney
2009-02-17 9:46 ` Ingo Molnar
2009-02-17 14:01 ` Paul E. McKenney
2009-02-17 15:39 ` Damien Wyart
2009-02-17 16:05 ` Paul E. McKenney
2009-02-17 21:48 ` Ingo Molnar
2009-02-17 4:34 ` Frederic Weisbecker
2009-02-17 15:10 ` Paul E. McKenney
2009-02-17 16:00 ` Frederic Weisbecker
2009-02-17 22:37 ` Frederic Weisbecker
2009-02-17 22:48 ` Paul E. McKenney
2009-02-18 0:38 ` Ingo Molnar
2009-02-18 1:02 ` Paul E. McKenney
2009-02-17 6:11 ` Damien Wyart
2009-02-17 15:11 ` Paul E. McKenney
2009-02-16 20:44 ` Damien Wyart
2009-02-15 10:12 ` Christian Kujau
2009-02-15 10:54 ` Ingo Molnar
2009-02-14 20:38 ` [Bug #12668] USB flash disk surprise disconnect Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12663] Commit 8c7e58e690ae60ab4215b025f433ed4af261e103 breaks resume Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12660] Linux 2.6.28.3 freezing on a 32-bits x86 Thinkpad T43p Rafael J. Wysocki
2009-02-14 23:29 ` Mathieu Desnoyers
2009-02-14 20:38 ` [Bug #12680] Not having a VIA PadLock hardware incurs a long delay in probing on modules insertion attempt Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12681] s2ram: fails to wake up on Acer Extensa 4220 (SMP disabled) Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12670] BUG: unable to handle kernel paging request at pin_to_kill+0x21 Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12671] uvc_status_cleanup(): undefined reference to `input_unregister_device' Rafael J. Wysocki
2009-02-14 20:38 ` [Bug #12705] X200: Brightness broken since 2.6.29-rc4-58-g4c098bc Rafael J. Wysocki
2009-02-15 13:43 ` Matthew Garrett
2009-02-15 14:37 ` Rafael J. Wysocki
2009-02-17 23:05 ` Eric Anholt
2009-02-17 23:13 ` Matthew Garrett
2009-02-17 23:23 ` Jesse Barnes
2009-02-18 9:36 ` Nico Schottelius
2009-02-13 9:33 ` Nico Schottelius
2009-02-13 9:40 ` Nico Schottelius
2009-02-13 13:43 ` Matthew Garrett
2009-03-10 2:28 ` Eric Anholt
2009-03-10 5:38 ` Nico Schottelius
2009-02-13 9:42 ` Ingo Molnar
2009-02-13 18:05 ` Len Brown
2009-02-16 9:06 ` ZhangRui
2009-02-16 10:58 ` Nico Schottelius
2009-02-16 13:13 ` Nico Schottelius
2009-02-16 21:40 ` Norbert Preining
2009-02-16 15:54 ` Nico Schottelius
2009-02-19 9:01 ` Nico Schottelius
2009-02-14 20:38 ` [Bug #12706] Oopses and ACPI problems (Linus 2.6.29-rc4) Rafael J. Wysocki
2009-02-16 7:29 ` 2.6.29-rc5: Reported regressions from 2.6.28 Jarek Poplawski
2009-02-16 21:11 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2009-02-23 21:45 2.6.29-rc6: " Rafael J. Wysocki
2009-02-23 21:48 ` [Bug #12613] [Suspend regression][DRM, RADEON] Rafael J. Wysocki
2009-02-24 6:56 ` etienne
2009-02-25 22:58 ` Rafael J. Wysocki
2009-02-27 10:14 ` Soeren Sonnenburg
2009-02-08 19:05 2.6.29-rc4: Reported regressions from 2.6.28 Rafael J. Wysocki
2009-02-08 19:21 ` [Bug #12613] [Suspend regression][DRM, RADEON] Rafael J. Wysocki
2009-02-08 22:07 ` etienne
2009-02-08 22:11 ` Rafael J. Wysocki
2009-02-09 2:26 ` Dave Airlie
2009-02-09 18:08 ` etienne
2009-02-09 19:31 ` etienne
2009-02-09 5:50 ` Soeren Sonnenburg
2009-02-04 10:21 2.6.29-rc3-git6: Reported regressions from 2.6.28 Rafael J. Wysocki
2009-02-04 10:24 ` [Bug #12613] [Suspend regression][DRM, RADEON] Rafael J. Wysocki
2009-02-04 22:25 ` etienne
2009-02-05 1:18 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4997EC57.1020608@numericable.fr \
--to=etienne.basset@numericable.fr \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=kernel-testers@vger.kernel.org \
--cc=kernel@nn7.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).