From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux1394-devel@lists.sourceforge.net,
Christian Dolzer <c.dolzer@digital-everywhere.com>,
Andreas Monitzer <andy@monitzer.com>,
Manu Abraham <manu@linuxtv.org>,
Fabio De Lorenzo <delorenzo.fabio@gmail.com>,
Robert Berger <robert.berger@reliableembeddedsystems.com>,
Ben Backx <ben@bbackx.com>, Henrik Kurelid <henrik@kurelid.se>,
Rambaldi <Rambaldi@xs4all.nl>
Subject: Re: [review patch 0/1] add firedtv driver for FireWire-attached DVB receivers
Date: Thu, 19 Feb 2009 20:40:39 +0100 [thread overview]
Message-ID: <499DB5B7.8080802@s5r6.in-berlin.de> (raw)
In-Reply-To: <20090217102951.21dab08c@pedra.chehab.org>
Mauro Carvalho Chehab wrote:
> The driver looks sane to my eyes. I found just one minor issue (see bellow).
> Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Thanks for checking.
>> +
>> + /*
>> + * AV/C specs say that answers should be sent within 150 ms.
>> + * Time out after 200 ms.
>> + */
>> + if (wait_event_timeout(fdtv->avc_wait,
>> + fdtv->avc_reply_received,
>> + HZ / 5) != 0) {
>
> Instead of using HZ, it would be better to use:
> msecs_to_jiffies(200)
OK, I switch this.
(Hmm, what if msecs_to_jiffies could be rolled out to a constant
expression if called on a constant argument...?)
--
Stefan Richter
-=====-==--= --=- =--==
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-02-19 19:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 19:32 [review patch 0/1] add firedtv driver for FireWire-attached DVB receivers Stefan Richter
2009-02-16 19:33 ` Stefan Richter
2009-02-16 19:36 ` Stefan Richter
2009-02-17 13:29 ` Mauro Carvalho Chehab
2009-02-19 19:40 ` Stefan Richter [this message]
2009-02-20 19:54 ` [PATCH -next] firedtv: build fix for INPUT=m and DVB_FIREDTV=y Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499DB5B7.8080802@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=Rambaldi@xs4all.nl \
--cc=andy@monitzer.com \
--cc=ben@bbackx.com \
--cc=c.dolzer@digital-everywhere.com \
--cc=delorenzo.fabio@gmail.com \
--cc=henrik@kurelid.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=manu@linuxtv.org \
--cc=mchehab@infradead.org \
--cc=robert.berger@reliableembeddedsystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).