From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
Christoph Lameter <cl@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Manfred Spraul <manfred@colorfullife.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH -mm 4/6] slqb: record slab's start address in slqb_page
Date: Tue, 03 Mar 2009 21:44:34 +0800 [thread overview]
Message-ID: <49AD3442.5040306@cn.fujitsu.com> (raw)
slqb's slab is coloring, it's will be useful that record the
color value or start address in struct slqb_page.
This fix adds a field in struct slqb_page to record slab's
start address, It will be used by kfree_rcu().
struct slqb_page has a field:
struct kmem_cache_list *list;
the corresponding field in struct page is:
union {
struct {
unsigned long private;
struct address_space *mapping;
};
struct kmem_cache *slab;
struct page *first_page;
};
It's large than 'struct kmem_cache_list *list;'
*So we are safe to add a field in struct page.*
(This field will not become a burden in future:)
struct page is very small, this fix uses the last room of
struct page. But if we have to add a more important
field in struct slqb_page in future, We can record slab's
color value in slqb_page instead of start address.
like this:
struct {
unsigned long flags;
atomic_t _count;
u16 inuse; /* use u16 instead */
u16 color; /* of unsigned int */
void *a_more_important_field;
struct kmem_cache_list *list;
void **freelist;
union {
struct list_head lru;
struct rcu_head rcu_head;
};
};
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/mm/slqb.c b/mm/slqb.c
index 48bdf3b..c258ddc 100644
--- a/mm/slqb.c
+++ b/mm/slqb.c
@@ -41,6 +41,7 @@ struct slqb_page {
unsigned long flags; /* mandatory */
atomic_t _count; /* mandatory */
unsigned int inuse; /* Nr of objects */
+ void *s_mem; /* start address */
struct kmem_cache_list *list; /* Pointer to list */
void **freelist; /* LIFO freelist */
union {
@@ -1010,6 +1011,7 @@ static struct slqb_page *new_slab_page(struct kmem_cache *s,
}
set_freepointer(s, last, NULL);
+ page->s_mem = start;
page->freelist = start;
page->inuse = 0;
out:
next reply other threads:[~2009-03-03 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 13:44 Lai Jiangshan [this message]
2009-03-23 7:54 ` [PATCH -mm 4/6] slqb: record slab's start address in slqb_page Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AD3442.5040306@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=paulmck@linux.vnet.ibm.com \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).