From: Dave <kilroyd@googlemail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Pavel Roskin <proski@gnu.org>,
git@vger.kernel.org, linux-kernel@vger.kernel.org,
orinoco-users@lists.sourceforge.net, dwmw2@infradead.org
Subject: Re: [Orinoco-users] linux-firmware binary corruption with gitweb
Date: Wed, 04 Mar 2009 23:52:09 +0000 [thread overview]
Message-ID: <49AF1429.9080009@gmail.com> (raw)
In-Reply-To: <m3iqmqt9ox.fsf@localhost.localdomain>
Jakub Narebski wrote:
> Dave <kilroyd@googlemail.com> writes:
>>> My strong impression is that the recoding takes place on the server. I
>>> think the bug should be reported to the gitweb maintainers unless it a
>>> local breakage on the kernel.org site.
>> Thanks Pavel.
>>
>> I just did a quick scan of the gitweb README - is this an issue with the
>> $mimetypes_file or $fallback_encoding configurations variables?
>
> First, what version of gitweb do you use? It should be in 'Generator'
> meta header, or (in older gitweb) in comments in HTML source at the
> top of the page.
Not sure where I'd find the meta header, but at the top of the HTML:
<!-- git web interface version 1.4.5-rc0.GIT-dirty, (C) 2005-2006, Kay
Sievers <kay.sievers@vrfy.org>, Christian Gierke -->
<!-- git core binaries version 1.6.1.1 -->
> Second, the file is actually sent to browser 'as is', using binmode :raw
> (or at least should be according to my understanding of Perl). And *.bin
> binary file gets application/octet-stream mimetype, and doesn't send any
> charset info. git.kernel.org should have modern enough gitweb to use this.
> Strange...
Dug around gitweb.perl in the main git repo. Then looked at the
git/warthog9/gitweb.git repo (after noting the Git Wiki says kernel.org
is running John Hawley's branch).
One notable change to git_blob_plain:
undef $/;
binmode STDOUT, ':raw';
- print <$fd>;
+ #print <$fd>;
+ $output .= <$fd>;
binmode STDOUT, ':utf8'; # as set at the beginning of gitweb.cgi
$/ = "\n";
close $fd;
+
+ return $output;
If that's the code that's running, doesn't that mean the output mode
change doesn't impact the concatenation to $output? So the blob gets utf
encoding when actually printed.
Regards,
Dave.
next prev parent reply other threads:[~2009-03-04 23:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-28 19:24 linux-firmware binary corruption with gitweb Dave
2009-03-01 5:47 ` [Orinoco-users] " Pavel Roskin
2009-03-03 18:59 ` Dave
2009-03-04 0:26 ` Jakub Narebski
2009-03-04 23:52 ` Dave [this message]
2009-03-05 17:26 ` Pavel Roskin
2009-03-06 0:03 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AF1429.9080009@gmail.com \
--to=kilroyd@googlemail.com \
--cc=dwmw2@infradead.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orinoco-users@lists.sourceforge.net \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).