From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764485AbZDHNgw (ORCPT ); Wed, 8 Apr 2009 09:36:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755196AbZDHNgl (ORCPT ); Wed, 8 Apr 2009 09:36:41 -0400 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:36414 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754023AbZDHNgk (ORCPT ); Wed, 8 Apr 2009 09:36:40 -0400 X-Sasl-enc: AdSl9B0Nu0p1+D5i+4MBaSiU7eegQcaoOlSYI5SFhdOP 1239197798 Message-ID: <49DCA863.3000800@fastmail.fm> Date: Wed, 08 Apr 2009 14:36:35 +0100 From: Jack Stone User-Agent: Thunderbird 2.0.0.21 (X11/20090325) MIME-Version: 1.0 To: Jesper Nilsson CC: "linux-kernel@vger.kernel.org" , "jeff@garzik.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH 08/56] cris: Remove void casts References: <1239189748-11703-1-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-2-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-3-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-4-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-5-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-6-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-7-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-8-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-9-git-send-email-jwjstone@fastmail.fm> <20090408123537.GI8115@axis.com> In-Reply-To: <20090408123537.GI8115@axis.com> Content-Type: multipart/mixed; boundary="------------050200070501080703020502" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a multi-part message in MIME format. --------------050200070501080703020502 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi Jesper, That patch might be wrong. Here's a revised version: Thanks Jack cris: Remove void casts From: Jack Stone Remove uneeded void casts Signed-Off-By: Jack Stone --- arch/cris/arch-v32/drivers/cryptocop.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c index 67c61ea..f2ffabb 100644 --- a/arch/cris/arch-v32/drivers/cryptocop.c +++ b/arch/cris/arch-v32/drivers/cryptocop.c @@ -2784,7 +2784,7 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig tmplen -= cop->tfrm_op.indata[0].iov_len; for (i = 1; itfrm_op.indata[i].iov_len = tmplen < PAGE_SIZE ? tmplen : PAGE_SIZE; - cop->tfrm_op.indata[i].iov_base = (unsigned char*)page_address(inpages[i]); + cop->tfrm_op.indata[i].iov_base = page_address(inpages[i]); tmplen -= PAGE_SIZE; } } else { --------------050200070501080703020502 Content-Type: text/plain; name="cris-remove-void-casts" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="cris-remove-void-casts" cris: Remove void casts From: Jack Stone Remove uneeded void casts Signed-Off-By: Jack Stone --- arch/cris/arch-v32/drivers/cryptocop.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c index 67c61ea..f2ffabb 100644 --- a/arch/cris/arch-v32/drivers/cryptocop.c +++ b/arch/cris/arch-v32/drivers/cryptocop.c @@ -2784,7 +2784,7 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig tmplen -= cop->tfrm_op.indata[0].iov_len; for (i = 1; itfrm_op.indata[i].iov_len = tmplen < PAGE_SIZE ? tmplen : PAGE_SIZE; - cop->tfrm_op.indata[i].iov_base = (unsigned char*)page_address(inpages[i]); + cop->tfrm_op.indata[i].iov_base = page_address(inpages[i]); tmplen -= PAGE_SIZE; } } else { --------------050200070501080703020502--