From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933141AbZDIKOf (ORCPT ); Thu, 9 Apr 2009 06:14:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759937AbZDIKOU (ORCPT ); Thu, 9 Apr 2009 06:14:20 -0400 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:41189 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754803AbZDIKOT (ORCPT ); Thu, 9 Apr 2009 06:14:19 -0400 X-Sasl-enc: tenuZ9m8brpXcvYaeDwxO6Q54pRtH9P6GSA+n1abHDfG 1239272057 Message-ID: <49DDCA76.6040509@fastmail.fm> Date: Thu, 09 Apr 2009 11:14:14 +0100 From: Jack Stone User-Agent: Thunderbird 2.0.0.21 (X11/20090325) MIME-Version: 1.0 To: linux-kernel@vger.kernel.org CC: jeff@garzik.org, kernel-janitors@vger.kernel.org, Trond.Myklebust@netapp.com Subject: Re: [PATCH 34/56] nfs: Remove void casts References: <> <1239189748-11703-20-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-21-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-22-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-23-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-24-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-25-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-26-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-27-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-28-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-29-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-30-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-31-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-32-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-33-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-34-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-35-git-send-email-jwjstone@fastmail.fm> In-Reply-To: <1239189748-11703-35-git-send-email-jwjstone@fastmail.fm> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Added maintainer CC] Jack Stone wrote: > Remove uneeded void casts > > Signed-Off-By: Jack Stone > --- > fs/nfs/inode.c | 2 +- > fs/nfs/nfs2xdr.c | 2 +- > fs/nfs/nfs3xdr.c | 2 +- > fs/nfs/nfs4xdr.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c > index 64f8719..c6aceaf 100644 > --- a/fs/nfs/inode.c > +++ b/fs/nfs/inode.c > @@ -1342,7 +1342,7 @@ void nfs4_clear_inode(struct inode *inode) > struct inode *nfs_alloc_inode(struct super_block *sb) > { > struct nfs_inode *nfsi; > - nfsi = (struct nfs_inode *)kmem_cache_alloc(nfs_inode_cachep, GFP_KERNEL); > + nfsi = kmem_cache_alloc(nfs_inode_cachep, GFP_KERNEL); > if (!nfsi) > return NULL; > nfsi->flags = 0UL; > diff --git a/fs/nfs/nfs2xdr.c b/fs/nfs/nfs2xdr.c > index c862c93..a9017a6 100644 > --- a/fs/nfs/nfs2xdr.c > +++ b/fs/nfs/nfs2xdr.c > @@ -627,7 +627,7 @@ nfs_xdr_readlinkres(struct rpc_rqst *req, __be32 *p, void *dummy) > } > > /* NULL terminate the string we got */ > - kaddr = (char *)kmap_atomic(rcvbuf->pages[0], KM_USER0); > + kaddr = kmap_atomic(rcvbuf->pages[0], KM_USER0); > kaddr[len+rcvbuf->page_base] = '\0'; > kunmap_atomic(kaddr, KM_USER0); > return 0; > diff --git a/fs/nfs/nfs3xdr.c b/fs/nfs/nfs3xdr.c > index e6a1932..48ccc17 100644 > --- a/fs/nfs/nfs3xdr.c > +++ b/fs/nfs/nfs3xdr.c > @@ -859,7 +859,7 @@ nfs3_xdr_readlinkres(struct rpc_rqst *req, __be32 *p, struct nfs_fattr *fattr) > } > > /* NULL terminate the string we got */ > - kaddr = (char*)kmap_atomic(rcvbuf->pages[0], KM_USER0); > + kaddr = kmap_atomic(rcvbuf->pages[0], KM_USER0); > kaddr[len+rcvbuf->page_base] = '\0'; > kunmap_atomic(kaddr, KM_USER0); > return 0; > diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c > index 1690f0e..a283caa 100644 > --- a/fs/nfs/nfs4xdr.c > +++ b/fs/nfs/nfs4xdr.c > @@ -3565,7 +3565,7 @@ static int decode_readlink(struct xdr_stream *xdr, struct rpc_rqst *req) > * and and null-terminate the text (the VFS expects > * null-termination). > */ > - kaddr = (char *)kmap_atomic(rcvbuf->pages[0], KM_USER0); > + kaddr = kmap_atomic(rcvbuf->pages[0], KM_USER0); > kaddr[len+rcvbuf->page_base] = '\0'; > kunmap_atomic(kaddr, KM_USER0); > return 0; >