From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765381AbZDIKhd (ORCPT ); Thu, 9 Apr 2009 06:37:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756814AbZDIKhW (ORCPT ); Thu, 9 Apr 2009 06:37:22 -0400 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:41682 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753081AbZDIKhU (ORCPT ); Thu, 9 Apr 2009 06:37:20 -0400 X-Sasl-enc: lKvWgX5U/6UQwQc3OFpMnonkJ7CYWE76eAVYncl4GCEU 1239273253 Message-ID: <49DDCF21.6000303@fastmail.fm> Date: Thu, 09 Apr 2009 11:34:09 +0100 From: Jack Stone User-Agent: Thunderbird 2.0.0.21 (X11/20090325) MIME-Version: 1.0 To: Bert Wesarg CC: linux-kernel@vger.kernel.org, jeff@garzik.org, kernel-janitors@vger.kernel.org, hch@infradead.org Subject: Re: [PATCH 51/56] sysv: Remove void casts References: <1239189748-11703-1-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-44-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-45-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-46-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-47-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-48-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-49-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-50-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-51-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-52-git-send-email-jwjstone@fastmail.fm> <36ca99e90904080502w1a9d703dg49a872b5539c3a9f@mail.gmail.com> <49DCAD50.6070601@fastmail.fm> In-Reply-To: <49DCAD50.6070601@fastmail.fm> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Added maintainer CC] Jack Stone wrote: > Fixed patch > > Thanks, > > Jack > > -- > > sysv: Remove void casts > > From: Jack Stone > > Remove uneeded void casts > > Signed-Off-By: Jack Stone > --- > > fs/sysv/dir.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/fs/sysv/dir.c b/fs/sysv/dir.c > index 56f6552..73b70a5 100644 > --- a/fs/sysv/dir.c > +++ b/fs/sysv/dir.c > @@ -87,7 +87,7 @@ static int sysv_readdir(struct file * filp, void * > dirent, filldir_t filldir) > > if (IS_ERR(page)) > continue; > - kaddr = (char *)page_address(page); > + kaddr = page_address(page); > de = (struct sysv_dir_entry *)(kaddr+offset); > limit = kaddr + PAGE_CACHE_SIZE - SYSV_DIRSIZE; > for ( ;(char*)de <= limit; de++) { > @@ -157,7 +157,7 @@ struct sysv_dir_entry *sysv_find_entry(struct dentry > *dentry, struct page **res_ > char *kaddr; > page = dir_get_page(dir, n); > if (!IS_ERR(page)) { > - kaddr = (char*)page_address(page); > + kaddr = page_address(page); > de = (struct sysv_dir_entry *) kaddr; > kaddr += PAGE_CACHE_SIZE - SYSV_DIRSIZE; > for ( ; (char *) de <= kaddr ; de++) { > @@ -201,7 +201,7 @@ int sysv_add_link(struct dentry *dentry, struct > inode *inode) > err = PTR_ERR(page); > if (IS_ERR(page)) > goto out; > - kaddr = (char*)page_address(page); > + kaddr = page_address(page); > de = (struct sysv_dir_entry *)kaddr; > kaddr += PAGE_CACHE_SIZE - SYSV_DIRSIZE; > while ((char *)de <= kaddr) { > @@ -244,7 +244,7 @@ int sysv_delete_entry(struct sysv_dir_entry *de, > struct page *page) > { > struct address_space *mapping = page->mapping; > struct inode *inode = (struct inode*)mapping->host; > - char *kaddr = (char*)page_address(page); > + char *kaddr = page_address(page); > loff_t pos = page_offset(page) + (char *)de - kaddr; > int err; > > @@ -278,7 +278,7 @@ int sysv_make_empty(struct inode *inode, struct > inode *dir) > } > kmap(page); > > - base = (char*)page_address(page); > + base = page_address(page); > memset(base, 0, PAGE_CACHE_SIZE); > > de = (struct sysv_dir_entry *) base; > @@ -312,7 +312,7 @@ int sysv_empty_dir(struct inode * inode) > if (IS_ERR(page)) > continue; > > - kaddr = (char *)page_address(page); > + kaddr = page_address(page); > de = (struct sysv_dir_entry *)kaddr; > kaddr += PAGE_CACHE_SIZE-SYSV_DIRSIZE; > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >