From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754821AbZDMILo (ORCPT ); Mon, 13 Apr 2009 04:11:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752690AbZDMILf (ORCPT ); Mon, 13 Apr 2009 04:11:35 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:59298 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbZDMILe (ORCPT ); Mon, 13 Apr 2009 04:11:34 -0400 Message-ID: <49E2F3B2.3080701@garzik.org> Date: Mon, 13 Apr 2009 04:11:30 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Marin Mitov CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH]Silencing warning: 'host' may be used uninitialized in this function References: <200904100133.58556.mitov@issp.bas.bg> <49DE78E4.2060201@garzik.org> <200904100231.32307.mitov@issp.bas.bg> In-Reply-To: <200904100231.32307.mitov@issp.bas.bg> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Marin Mitov wrote: > On Friday 10 April 2009 01:38:28 am Jeff Garzik wrote: >> Marin Mitov wrote: >>> Hi all, >>> >>> I do not know if that is worth the effort, but... >>> >>> Silencing: warning: 'host' may be used uninitialized in this function >>> It is a false positive. >>> >>> The patch is against 2.6.30-rc1, but should apply to 2.6.29(.1) too. >>> >>> Signed-off-by: Marin Mitov mitov@issp.bas.bg >>> ================================================ >>> --- a/drivers/ata/sata_via.c 2009-04-05 22:59:26.000000000 +0300 >>> +++ b/drivers/ata/sata_via.c 2009-04-06 00:07:25.000000000 +0300 >>> @@ -566,7 +566,7 @@ >>> static int printed_version; >>> unsigned int i; >>> int rc; >>> - struct ata_host *host; >>> + struct ata_host *host = host; >>> int board_id = (int) ent->driver_data; >>> const unsigned *bar_sizes; >> we use the uninitialized_var() macro for false positives. >> >> Jeff >> > > Well, changed and resubmitted. > > Marin Mitov > > Silencing: " warning: 'host' may be used uninitialized in this function" > > The patch is against 2.6.30-rc1, but should apply to 2.6.29(.1) too. > > Signed-off-by: Marin Mitov mitov@issp.bas.bg > ================================================ > --- a/drivers/ata/sata_via.c 2009-04-05 22:59:26.000000000 +0300 > +++ b/drivers/ata/sata_via.c 2009-04-06 00:07:25.000000000 +0300 > @@ -566,7 +566,7 @@ > static int printed_version; > unsigned int i; > int rc; > - struct ata_host *host; > + struct ata_host *uninitialized_var(host); > int board_id = (int) ent->driver_data; > const unsigned *bar_sizes; I did this a slightly different way... I went ahead and simply initialized it. Jeff