From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754405AbZDMQdT (ORCPT ); Mon, 13 Apr 2009 12:33:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750767AbZDMQdE (ORCPT ); Mon, 13 Apr 2009 12:33:04 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:53523 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752546AbZDMQdD (ORCPT ); Mon, 13 Apr 2009 12:33:03 -0400 Message-ID: <49E36939.2050402@garzik.org> Date: Mon, 13 Apr 2009 12:32:57 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Alan Cox CC: Mark Lord , linux-ide@vger.kernel.org, LKML , gwendal@google.com Subject: Re: [PROPOSED] ata: Report 16/32bit PIO as best we can References: <20090409133221.18202.63779.stgit@t61.ukuu.org.uk> <49DDF1EB.2060200@rtr.ca> <20090409140857.578a9146@lxorguk.ukuu.org.uk> In-Reply-To: <20090409140857.578a9146@lxorguk.ukuu.org.uk> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alan Cox wrote: >> But.. these do look rather suspiciously like sysfs attrs to me. > > I'd rather any future sysfs interface actually exposed something more > meaningful. This is a legacy fixup 8) > >> We didn't have a sysfs in the IDE days (so Gadi added the klunky >> procfs "settings" thing for there), but we do now. >> >> I'm happy to update hdparm to check sysfs if that's where this >> ends up, or to do almost nothing for it if we stick with the ioctls. > > I'm not sure sysfs helps much anyway - you have to open the device file > and keep it open while accessing the sysfs nodes anyway (something huge > numbers of apps hopelessly fail to do so) FWIW... here is the sysfs work I referred to (in a message sent several days ago in this thread)... http://lwn.net/Articles/294608/ Jeff