From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757024AbZDOGli (ORCPT ); Wed, 15 Apr 2009 02:41:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751438AbZDOGl3 (ORCPT ); Wed, 15 Apr 2009 02:41:29 -0400 Received: from TYO201.gate.nec.co.jp ([202.32.8.193]:60327 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751307AbZDOGl3 (ORCPT ); Wed, 15 Apr 2009 02:41:29 -0400 Message-ID: <49E58168.3090409@ct.jp.nec.com> Date: Wed, 15 Apr 2009 15:40:40 +0900 From: Hiroshi Shimamoto User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Andrew Morton CC: minyard@acm.org, linux-kernel@vger.kernel.org, openipmi-developer@lists.sourceforge.net Subject: Re: [PATCH 4/5] IPMI: Add console oops catcher References: <20090303152123.GD7777@minyard.local> <20090303132046.a8975963.akpm@linux-foundation.org> <49ADC559.7040705@ct.jp.nec.com> <20090402141445.3a7a6504.akpm@linux-foundation.org> In-Reply-To: <20090402141445.3a7a6504.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > On Tue, 03 Mar 2009 16:03:37 -0800 > Hiroshi Shimamoto wrote: > >> ... >>> This reader is unable to determine what the mystery preempt_disable() >>> is here for. It needs a comment, please. >> I cannot recall why it's here. So a comment is really needed. >> This preempt_disable() may not be needed. >> >>> What happens if two CPUs oops at the same time (which is fairly common)? >> ... >> >> OK. I'll look at this. >> >>> It would be prudent to have a timeout in this loop. The machine has >>> crashed and subsystems and hardware and memory are in an unknown and >>> possibly bad state. >> Right. >> >> ... >> >>> This looks like we're abusing the "unblank" method. >>> >>> If you think that the console subsystem is missing some capability >>> which this driver needs then please do prefer to fix the console >>> subsystem, rather than awkwardly making things fit. >> OK. Will take a look about this point. >> > > None of this happened. > > It makes me reluctant to merge that patches as they stand, because then > it all gets forgotten about, whereas holding the patches back will > remind us that updates are needed. Sorry for late reply. I couldn't have time for this patch. I'll look at this again and will resend updates. Thanks, Hiroshi