From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1EECC433FE for ; Mon, 1 Nov 2021 22:41:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8213560EBC for ; Mon, 1 Nov 2021 22:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232280AbhKAWnx (ORCPT ); Mon, 1 Nov 2021 18:43:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229848AbhKAWnw (ORCPT ); Mon, 1 Nov 2021 18:43:52 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A143C061714; Mon, 1 Nov 2021 15:41:18 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id d3so30357411wrh.8; Mon, 01 Nov 2021 15:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QCoZhc5ZEGa1eJqhbNdTunCmt1mUsYpZECTvHZXwgFI=; b=fA5efdRvGBGpmb3I1GHYpJV3T4DJCXa5+8einDt2W5pCa3lAL9WvbUG7dr9w4k6C90 uZgiJ96ANLa/Wt3DeD6DRAMbFACgPtkvljIoWX4kB9JTnBdvFKSaeKP+CCC75IE/fOkG 8nxcgPGWeYciFQkvkJqs04+S4C5IXlj6Vbwwz970SPdr2icRrQaDGf0mqTgBvEwwaLs4 DlXfD3vKYJ3adexSbdZmFiIFZkDvEA+czDCI+Ov3LPvMitN2clMTNXU1CLbNaq6LkWVc XIIFO1TWFKMmfeKGQWCgihH61ccZOS9XLaWYAhLuFPeDpp4c7/9K72kXZ/5fbhwEuccj e9MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QCoZhc5ZEGa1eJqhbNdTunCmt1mUsYpZECTvHZXwgFI=; b=2U57H75gUa+Xh+Q0HcSaJEBShbORargLPBgAGx3qlH+lGKrVCKxAKLcgAWXM8xItnl kuU1UFfV+3FEXtFYYgd600yYnHuTHK17/1l4QE/PJNE8wH7Z1lmgWX1U2+BU2o42TfjI nHmZNliIPIRyeYmNA32G8Pnd/qQvJb+nMx/oVptNLwioOF0aCPkZKEesXDx/kSjBwNkS AXXdOBIfZIxNOXVPb8GFBIEj7dYY1BMFE6Q7K2l0qD7BZ30hxupJSdR2wvzwu0UL8ze+ WyPydhInqtVgU5JaBvlW9z5QOvAPmU5D+YvGZl/BGZiWMtcYDLPsSoKc7eEK+3aEQpFF 8LrQ== X-Gm-Message-State: AOAM531YCSkMsEXem2Na9Rp4uJ+dhIsZIfKmLK4OfqutARCsg7JxBaLx n918eQWeLWZm8WzdzLiKcg== X-Google-Smtp-Source: ABdhPJz4a0/IqbecY1aKyjjiYSSeUqq/i/xmPeUEBlTSWGYs3WCoE4LLypqNx0J+daTVFqh4zaKcxw== X-Received: by 2002:adf:a28f:: with SMTP id s15mr40683184wra.138.1635806476771; Mon, 01 Nov 2021 15:41:16 -0700 (PDT) Received: from [192.168.200.23] (ip5b435a69.dynamic.kabel-deutschland.de. [91.67.90.105]) by smtp.gmail.com with ESMTPSA id k187sm1100084wme.0.2021.11.01.15.41.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Nov 2021 15:41:16 -0700 (PDT) Subject: Re: [PATCH] clk: composite: Also consider .determine_rate for rate + mux composites To: Robin Murphy , Martin Blumenstingl , Guillaume Tucker Cc: sboyd@kernel.org, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, "kernelci@groups.io" , Collabora Kernel ML , Chen-Yu Tsai References: <163425193558.1688384.15520943968787313145@swboyd.mtv.corp.google.com> <20211015120559.3515645-1-martin.blumenstingl@googlemail.com> <04a58d50-634b-fa20-95b4-eb6831f77e85@collabora.com> <3e42ae24-8db4-fb11-edf2-a25bca47ecae@arm.com> From: Alex Bee Message-ID: <49a0dda1-8d0f-580c-d92d-de759b51edb3@gmail.com> Date: Mon, 1 Nov 2021 23:41:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <3e42ae24-8db4-fb11-edf2-a25bca47ecae@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guillaume, Am 01.11.21 um 23:11 schrieb Robin Murphy: > On 2021-11-01 21:59, Robin Murphy wrote: >> On 2021-11-01 20:58, Martin Blumenstingl wrote: >>> Hi Guillaume, >>> >>> On Mon, Nov 1, 2021 at 9:19 PM Guillaume Tucker >>> wrote: >>>> >>>> Hi Martin, >>>> >>>> Please see the bisection report below about a boot failure on >>>> rk3328-rock64. >>>> >>>> Reports aren't automatically sent to the public while we're >>>> trialing new bisection features on kernelci.org but this one >>>> looks valid. >>>> >>>> Some more details can be found here: >>>> >>>>    https://linux.kernelci.org/test/case/id/617f11f5c157b666fb3358e6/ >>>> >>>> Here's what appears to be the cause of the problem: >>>> >>>> [    0.033465] CPU: CPUs started in inconsistent modes >>>> [    0.033557] Unexpected kernel BRK exception at EL1 >>>> [    0.034432] Internal error: BRK handler: f2000800 [#1] PREEMPT SMP >> >> What's weird is that that's really just the same WARN that's also >> present in 'successful' logs, except for some reason it's behaving as >> if the break handler hasn't been registered, despite that having >> happened long before we got to smp_init(). At this point we're also >> still some way off getting as far as initcalls, so I'm not sure that >> the clock driver would be in the picture at all yet. >> >> Is the bisection repeatable, or is this just random flakiness >> misleading things? I'd also note that you need pretty horrifically >> broken firmware to hit that warning in the first place, which might >> cast a bit of doubt over the trustworthiness of that board altogether. > > Ah, on closer inspection it might be entirely repeatable for a given > kernel build, but with the behaviour being very sensitive to code/data > segment layout changes... > > ... > 23:44:24.457917  Filename '1007060/tftp-deploy-dvdnydcw/kernel/Image'. > 23:44:24.460178  Load address: 0x2000000 > ... > 23:44:27.180962  Bytes transferred = 33681920 (201f200 hex) > ... > 23:44:27.288135  Filename > '1007060/tftp-deploy-dvdnydcw/ramdisk/ramdisk.cpio.gz.uboot'. > 23:44:27.288465  Load address: 0x4000000 > ... could you try updating u-boot to more recent version: the ramdisk address has been moved [1] to 0x06000000 in v2020.01-rc5. I couldn't reproduce this issue with the very same board. [1] https://github.com/u-boot/u-boot/commit/b2e373d16b0345d3c3f4beefdf0889e83faf173d Alex > > Yeah, that'll be a problem ;) > > Cheers, > Robin. > >>>> There doesn't appear to be any other platform in KernelCI showing >>>> the same issue. >>> That's a strange error for the changes from my patch. >>> At first glance I don't see any relation to clk-composite code: >>> - the call trace doesn't have any references to CCF or rockchip clock >>> drivers >>> - clk-rk3328.c uses drivers/clk/rockchip/clk-cpu.c to register the CPU >>> clock which does not use clk-composite >>> >>> Chen-Yu has tested this patch (plus [0]) on RK3399 and didn't observe >>> any problems. >>> So maybe this is a RK3328 specific issue? >>> Anyways, I am interested in fixing this issue because reverting is >>> becoming more and more complex (since I think we're at eight commits >>> which would need to be reverted in total). >>> >>>> Please let us know if you need help debugging the issue or if you >>>> have a fix to try. >>> Could you please try [0] which is the second patch in the series which >>> finally made it upstream. >>> This second patch is not in 5.15 because I believed that it's only >>> something to make the code in clk-composite.c more future-proof. It's >>> not a condition that I am aware of. >>> >>> I don't have any Rockchip boards myself. >>> So I am thankful for any help I can get. >>> >>> >>> Best regards, >>> Martin >>> >>> >>> [0] >>> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=6594988fd625ff0d9a8f90f1788e16185358a3e6 >>> >>> >>> _______________________________________________ >>> Linux-rockchip mailing list >>> Linux-rockchip@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-rockchip >>> >> >> _______________________________________________ >> Linux-rockchip mailing list >> Linux-rockchip@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-rockchip