From: Yuehaibing <yuehaibing@huawei.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>,
Simon Horman <simon.horman@netronome.com>
Cc: Egor Pomozov <epomozov@marvell.com>,
"davem@davemloft.net" <davem@davemloft.net>,
Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>,
"Sergey Samoilenko" <Sergey.Samoilenko@aquantia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH net-next] net: aquantia: Fix build error wihtout CONFIG_PTP_1588_CLOCK
Date: Mon, 28 Oct 2019 15:49:25 +0800 [thread overview]
Message-ID: <49a629ba-c143-896a-d24d-32e04c430b77@huawei.com> (raw)
In-Reply-To: <379afbe8-adb8-5209-ac65-8bb9fb92966a@aquantia.com>
On 2019/10/26 19:09, Igor Russkikh wrote:
>
>>> Hi YueHaibing,
>>>
>>> thanks for your patch.
>>>
>>> What is the motivation for not using the existing copy of this function?
>>
>> I'm not sure if PTP_1588_CLOCK is needed at this config,
>> using the existing function need to PTP_1588_CLOCK is selected.
>
> Hi YueHaibing,
>
> Please checkout this patch: https://patchwork.ozlabs.org/patch/1184620/
>
> It fixes the problem without duplicating the function.
Yes, this fix the issue.
>
> Regards,
> Igor
>
>
prev parent reply other threads:[~2019-10-28 7:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 13:37 [PATCH net-next] net: aquantia: Fix build error wihtout CONFIG_PTP_1588_CLOCK YueHaibing
2019-10-25 15:06 ` [EXT] " Igor Russkikh
2019-10-26 8:09 ` Simon Horman
2019-10-26 8:57 ` Yuehaibing
2019-10-26 11:09 ` [EXT] " Igor Russkikh
2019-10-28 7:49 ` Yuehaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a629ba-c143-896a-d24d-32e04c430b77@huawei.com \
--to=yuehaibing@huawei.com \
--cc=Dmitry.Bezrukov@aquantia.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=Sergey.Samoilenko@aquantia.com \
--cc=davem@davemloft.net \
--cc=epomozov@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).