From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jiang Jian <jiangjian@cdjrlc.com>, axboe@kernel.dk
Cc: philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
christoph.boehmwalder@linbit.com, drbd-dev@lists.linbit.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: drbd: drbd_state: Fix typo in comments
Date: Wed, 22 Jun 2022 12:10:59 -0400 [thread overview]
Message-ID: <49a877f33a088edc232eb98029e46e53884c5cd6.camel@HansenPartnership.com> (raw)
In-Reply-To: <20220622155220.8704-1-jiangjian@cdjrlc.com>
On Wed, 2022-06-22 at 23:52 +0800, Jiang Jian wrote:
> Replace 'is' with 'it'
>
> file: drivers/block/drbd/drbd_state.c
> line: 1900
>
> * But is is still not save to dreference ldev here, since
>
> changed to:
>
> * But it is still not save to dreference ldev here, since
I honestly don't think spelling and grammar updates to comments provide
much value. However, there's no value at all if it's still two
spelling errors in that one line after the proposed patch ...
James
next prev parent reply other threads:[~2022-06-22 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 15:52 [PATCH] block: drbd: drbd_state: Fix typo in comments Jiang Jian
2022-06-22 16:10 ` James Bottomley [this message]
2022-06-22 20:57 ` Christoph Böhmwalder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a877f33a088edc232eb98029e46e53884c5cd6.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=axboe@kernel.dk \
--cc=christoph.boehmwalder@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=jiangjian@cdjrlc.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).