From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753547AbdKJSWp (ORCPT ); Fri, 10 Nov 2017 13:22:45 -0500 Received: from aibo.runbox.com ([91.220.196.211]:48822 "EHLO aibo.runbox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753148AbdKJSWn (ORCPT ); Fri, 10 Nov 2017 13:22:43 -0500 Subject: Re: [PATCH net-next 0/2] net: dsa: lan9303: IGMP handling To: Andrew Lunn Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171110115435.4261-1-privat@egil-hjelmeland.no> <20171110140719.GC11872@lunn.ch> From: Egil Hjelmeland Message-ID: <49a8be62-683e-aac6-b3f3-eef7295a49ca@egil-hjelmeland.no> Date: Fri, 10 Nov 2017 19:22:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171110140719.GC11872@lunn.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 10. nov. 2017 15:07, skrev Andrew Lunn: >> skb->offload_fwd_mark calculation is a candidate for consolidation into the >> DSA core. The calculation can probably be more polished when done at a point >> where DSA has updated skb. > > Hi Egil > > Yes, at some point we should do this. But at the moment it is too > early. We don't have enough experience with what the different > switches need. I would like to see 4 or more devices doing it before > we consolidate the code into the core. > Absolutely. My point was rather I prefer not spend time polishing this snippet right now, because it will probably be refactored later anyway. One steppingstone could be to make reusable helper-functions in net/dsa/dsa_priv.h. But I leave that to device #2 that implement this ;-) > Andrew > Egil