From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH RESEND 0/4] regulator: debugging and fixing supply deps
Date: Fri, 13 Nov 2020 12:22:53 +0100 [thread overview]
Message-ID: <49aaa901-041d-e803-2ec5-167d8bb6372f@pengutronix.de> (raw)
In-Reply-To: <0cb181b3-d257-b7a4-56e4-0d2bb04b0387@pengutronix.de>
CC += linux-stm32 as other STM32MP1 boards are also affected.
On 11/13/20 12:19 PM, Ahmad Fatoum wrote:
> Hello Michał,
>
> On 11/13/20 1:20 AM, Michał Mirosław wrote:
>> It turns out that commit aea6cb99703e ("regulator: resolve supply
>> after creating regulator") exposed a number of issues in regulator
>> initialization and introduced a memory leak of its own. One uncovered
>> problem was already fixed by cf1ad559a20d ("regulator: defer probe when
>> trying to get voltage from unresolved supply"). This series fixes the
>> remaining ones and adds a two debugging aids to help in the future.
>>
>> The final patch adds a workaround to preexisting problem occurring with
>> regulators that have the same name as its supply_name. This worked
>> before by accident, so might be worth backporting. The error message is
>> left on purpose so that these configurations can be detected and fixed.
>>
>> (The first two patches are resends from Nov 5).
>>
>> (Series resent because of wrong arm-kernel ML address.)
>
> lxa-mc1 (STM32MP1 board with STPMIC) now manages to boot again with following
> new warning:
>
> stpmic1-regulator 5c002000.i2c:stpmic@33:regulators: Supply for VREF_DDR
>
> So for the whole series,
> Tested-by: Ahmad Fatoum <a.fatoum@pengutronix.de> # stpmic1
>
> Thanks!
> Ahmad
>
>>
>> Michał Mirosław (4):
>> regulator: fix memory leak with repeated set_machine_constraints()
>> regulator: debug early supply resolving
>> regulator: avoid resolve_supply() infinite recursion
>> regulator: workaround self-referent regulators
>>
>> drivers/regulator/core.c | 40 ++++++++++++++++++++++++----------------
>> 1 file changed, 24 insertions(+), 16 deletions(-)
>>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2020-11-13 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 0:20 [PATCH RESEND 0/4] regulator: debugging and fixing supply deps Michał Mirosław
2020-11-13 0:20 ` [PATCH RESEND 2/4] regulator: debug early supply resolving Michał Mirosław
2020-11-13 13:16 ` Mark Brown
2020-11-13 0:20 ` [PATCH RESEND 1/4] regulator: fix memory leak with repeated set_machine_constraints() Michał Mirosław
2020-11-13 0:20 ` [PATCH RESEND 3/4] regulator: avoid resolve_supply() infinite recursion Michał Mirosław
2020-11-13 0:20 ` [PATCH RESEND 4/4] regulator: workaround self-referent regulators Michał Mirosław
2020-11-13 11:19 ` [PATCH RESEND 0/4] regulator: debugging and fixing supply deps Ahmad Fatoum
2020-11-13 11:22 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49aaa901-041d-e803-2ec5-167d8bb6372f@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mirq-linux@rere.qmqm.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).