From: David Hildenbrand <david@redhat.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [External] Re: [PATCH v2] mm/page_isolation: do not isolate the max order page
Date: Fri, 4 Dec 2020 18:12:55 +0100 [thread overview]
Message-ID: <49b09de4-4b21-e6a7-0730-e125fcb398b3@redhat.com> (raw)
In-Reply-To: <CAMZfGtVdFtLB8f2uDfJ1H-YG4CsJ+RxxFbAWzePDnqBB1MU0ig@mail.gmail.com>
On 04.12.20 17:12, Muchun Song wrote:
> On Fri, Dec 4, 2020 at 12:28 AM David Hildenbrand <david@redhat.com> wrote:
>>
>> On 03.12.20 17:22, Muchun Song wrote:
>>> The max order page has no buddy page and never merge to other order.
>>> So isolating and then freeing it is pointless. And if order == MAX_ORDER
>>> - 1, then the buddy can actually be a !pfn_valid() in some corner case?
>>> pfn_valid_within(buddy_pfn) that follows would only catch it on archs
>>> with holes in zone. Then is_migrate_isolate_page(buddy) might access an
>>> invalid buddy. So this is also a bug fix.
>>>
>>> Fixes: 3c605096d315 ("mm/page_alloc: restrict max order of merging on isolated pageblock")
>>
>> As just replied to v1, I don't think this is required and the patch
>
> You mean we should remove the Fixes tag? Thanks.
As discussed in v1, I don't think we really have systems where this
applies, but could be in corner cases on MIPS or with FLATMEM. Let's
just leave it like that. :)
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-12-04 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 16:22 [PATCH v2] mm/page_isolation: do not isolate the max order page Muchun Song
2020-12-03 16:28 ` David Hildenbrand
2020-12-04 16:12 ` [External] " Muchun Song
2020-12-04 17:12 ` David Hildenbrand [this message]
2020-12-07 13:42 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49b09de4-4b21-e6a7-0730-e125fcb398b3@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=songmuchun@bytedance.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).