From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45CA8C433DB for ; Sat, 30 Jan 2021 18:48:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A00964DD9 for ; Sat, 30 Jan 2021 18:48:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230360AbhA3SsP (ORCPT ); Sat, 30 Jan 2021 13:48:15 -0500 Received: from smtprelay0171.hostedemail.com ([216.40.44.171]:40950 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230045AbhA3SsM (ORCPT ); Sat, 30 Jan 2021 13:48:12 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 9F2FF182CED34; Sat, 30 Jan 2021 18:47:30 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: root04_1201875275b3 X-Filterd-Recvd-Size: 3185 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Sat, 30 Jan 2021 18:47:29 +0000 (UTC) Message-ID: <49b8e2550e661d5f8a5d0b353ec23819cdcae3d2.camel@perches.com> Subject: Re: [PATCH 09/29] drm/gma500: Avoid comma separated statements From: Joe Perches To: Jiri Kosina , Patrik Jakobsson Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Sat, 30 Jan 2021 10:47:28 -0800 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > Use semicolons and braces. Ping? > Signed-off-by: Joe Perches > --- >  drivers/gpu/drm/gma500/mdfld_intel_display.c | 44 +++++++++++++------- >  1 file changed, 28 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c > index aae2d358364c..bfa330df9443 100644 > --- a/drivers/gpu/drm/gma500/mdfld_intel_display.c > +++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c > @@ -824,33 +824,45 @@ static int mdfld_crtc_mode_set(struct drm_crtc *crtc, >   if ((ksel == KSEL_CRYSTAL_19) || (ksel == KSEL_BYPASS_19)) { >   refclk = 19200; >   > > - if (is_mipi || is_mipi2) > - clk_n = 1, clk_p2 = 8; > - else if (is_hdmi) > - clk_n = 1, clk_p2 = 10; > + if (is_mipi || is_mipi2) { > + clk_n = 1; > + clk_p2 = 8; > + } else if (is_hdmi) { > + clk_n = 1; > + clk_p2 = 10; > + } >   } else if (ksel == KSEL_BYPASS_25) { >   refclk = 25000; >   > > - if (is_mipi || is_mipi2) > - clk_n = 1, clk_p2 = 8; > - else if (is_hdmi) > - clk_n = 1, clk_p2 = 10; > + if (is_mipi || is_mipi2) { > + clk_n = 1; > + clk_p2 = 8; > + } else if (is_hdmi) { > + clk_n = 1; > + clk_p2 = 10; > + } >   } else if ((ksel == KSEL_BYPASS_83_100) && >   dev_priv->core_freq == 166) { >   refclk = 83000; >   > > - if (is_mipi || is_mipi2) > - clk_n = 4, clk_p2 = 8; > - else if (is_hdmi) > - clk_n = 4, clk_p2 = 10; > + if (is_mipi || is_mipi2) { > + clk_n = 4; > + clk_p2 = 8; > + } else if (is_hdmi) { > + clk_n = 4; > + clk_p2 = 10; > + } >   } else if ((ksel == KSEL_BYPASS_83_100) && >   (dev_priv->core_freq == 100 || >   dev_priv->core_freq == 200)) { >   refclk = 100000; > - if (is_mipi || is_mipi2) > - clk_n = 4, clk_p2 = 8; > - else if (is_hdmi) > - clk_n = 4, clk_p2 = 10; > + if (is_mipi || is_mipi2) { > + clk_n = 4; > + clk_p2 = 8; > + } else if (is_hdmi) { > + clk_n = 4; > + clk_p2 = 10; > + } >   } >   > >   if (is_mipi)