From: Robin Murphy <robin.murphy@arm.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Tomasz Figa <tfiga@google.com>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
anan.sun@mediatek.com, chao.hao@mediatek.com,
jun.wen@mediatek.com
Subject: Re: [PATCH v2 4/6] iommu: Add granule_ignore when tlb gather
Date: Wed, 25 Nov 2020 16:38:35 +0000 [thread overview]
Message-ID: <49bae447-d662-e6cf-7500-ab78e3b75dc4@arm.com> (raw)
In-Reply-To: <20201119061836.15238-5-yong.wu@mediatek.com>
On 2020-11-19 06:18, Yong Wu wrote:
> Add a granule_ignore option when tlb gather for some HW which don't care
> about granule when it flush tlb.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> include/linux/iommu.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 794d4085edd3..1aad32238510 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -171,6 +171,7 @@ enum iommu_dev_features {
> * @start: IOVA representing the start of the range to be flushed
> * @end: IOVA representing the end of the range to be flushed (exclusive)
> * @pgsize: The interval at which to perform the flush
> + * @granule_ignore: For tlb flushing that could be regardless of granule.
> *
> * This structure is intended to be updated by multiple calls to the
> * ->unmap() function in struct iommu_ops before eventually being passed
> @@ -180,6 +181,7 @@ struct iommu_iotlb_gather {
> unsigned long start;
> unsigned long end;
> size_t pgsize;
> + bool granule_ignore;
I can't see that this would ever need to vary on a per-unmap-operation
basis, so this doesn't seem like the right level of abstraction. AFAICS
it should simply be hard-coded in the driver logic.
> };
>
> /**
> @@ -544,7 +546,7 @@ static inline void iommu_iotlb_gather_add_page(struct iommu_domain *domain,
> * a different granularity, then sync the TLB so that the gather
> * structure can be rewritten.
> */
> - if (gather->pgsize != size ||
> + if ((!gather->granule_ignore && gather->pgsize != size) ||
I also think this is a slippery slope in the wrong direction anyway -
there is likely to be a fair bit of hardware-dependent variation around
how low-level TLB maintenance works (also consider drivers that may want
to convert a sufficiently large range to an "invalidate all" operation),
so if a generic helper function doesn't do the right thing for a given
driver, that driver should simply not use the helper, and directly
implement the logic it does need.
Robin.
> end < gather->start || start > gather->end) {
> if (gather->pgsize)
> iommu_iotlb_sync(domain, gather);
>
next prev parent reply other threads:[~2020-11-25 16:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 6:18 [PATCH v2 0/6] MediaTek IOMMU improve tlb flush performance in map/unmap Yong Wu
2020-11-19 6:18 ` [PATCH v2 1/6] iommu: Move iotlb_sync_map out from __iommu_map Yong Wu
2020-11-25 16:37 ` Robin Murphy
2020-11-19 6:18 ` [PATCH v2 2/6] iommu: Add iova and size as parameters in iommu_iotlb_map Yong Wu
2020-11-25 16:38 ` Robin Murphy
2020-11-19 6:18 ` [PATCH v2 3/6] iommu/mediatek: Add iotlb_sync_map to sync whole the iova range Yong Wu
2020-11-19 15:33 ` kernel test robot
2020-11-19 16:11 ` kernel test robot
2020-11-25 16:38 ` Robin Murphy
2020-11-19 6:18 ` [PATCH v2 4/6] iommu: Add granule_ignore when tlb gather Yong Wu
2020-11-25 16:38 ` Robin Murphy [this message]
2020-11-19 6:18 ` [PATCH v2 5/6] iommu/mediatek: Enable granule_ignore for unmap Yong Wu
2020-11-19 6:18 ` [PATCH v2 6/6] iommu/mediatek: Convert tlb_flush_walk to gather_add_page Yong Wu
2020-11-25 16:38 ` Robin Murphy
2020-11-25 12:27 ` [PATCH v2 0/6] MediaTek IOMMU improve tlb flush performance in map/unmap Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49bae447-d662-e6cf-7500-ab78e3b75dc4@arm.com \
--to=robin.murphy@arm.com \
--cc=anan.sun@mediatek.com \
--cc=chao.hao@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=jun.wen@mediatek.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).