From: Parthiban Nallathambi <pn@denx.de>
To: Rob Herring <robh@kernel.org>
Cc: marc.zyngier@arm.com, tglx@linutronix.de, jason@lakedaemon.net,
mark.rutland@arm.com, afaerber@suse.de, catalin.marinas@arm.com,
will.deacon@arm.com, manivannan.sadhasivam@linaro.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
thomas.liau@actions-semi.com, mp-cs@actions-semi.com,
linux@cubietech.com, edgar.righi@lsitec.org.br,
laisa.costa@lsitec.org.br, guilherme.simoes@lsitec.org.br,
mkzuffo@lsi.usp.br, Saravanan Sekar <sravanhome@gmail.com>,
pn@denx.de
Subject: Re: [PATCH v3 1/4] dt-bindings: interrupt-controller: Actions external interrupt controller
Date: Sun, 9 Dec 2018 20:26:40 +0100 [thread overview]
Message-ID: <49bb60b8-a51b-a4e8-da29-52f0a951c37b@denx.de> (raw)
In-Reply-To: <20181207232934.GA28201@bogus>
Hello Rob,
On 12/8/18 12:29 AM, Rob Herring wrote:
> On Mon, Nov 26, 2018 at 11:03:53AM +0100, Parthiban Nallathambi wrote:
>> Actions Semi OWL family SoC's provides support for external interrupt
>> controller to be connected and controlled using SIRQ pins. S500, S700
>> and S900 provides 3 SIRQ lines and works independently for 3 external
>> interrupt controllers.
>>
>> Signed-off-by: Parthiban Nallathambi <pn@denx.de>
>> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
>> ---
>> .../interrupt-controller/actions,owl-sirq.txt | 57 +++++++++++++++++++
>> 1 file changed, 57 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt
>> new file mode 100644
>> index 000000000000..b3adc4bddf40
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt
>> @@ -0,0 +1,57 @@
>> +Actions Semi Owl SoCs SIRQ interrupt controller
>> +
>> +S500, S700 and S900 SoC's from Actions provides 3 SPI's from GIC,
>
> Listing SoCs here means you have to update this line for every new SoC.
Ok, I will mark it as OWL SoC's here.
>
>> +in which external interrupt controller can be connected. 3 SPI's
>> +45, 46, 47 from GIC are directly exposed as SIRQ. It has
>> +the following properties:
>> +
>> +- inputs three interrupt signal from external interrupt controller
>> +
>> +Required properties:
>> +
>> +- compatible: should be "actions,owl-sirq"
>
> SoC specific compatibles needed.
Ok, I will change this into "actions,s700-sirq"
>
>> +- reg: physical base address of the controller and length of memory mapped
>> + region.
>> +- interrupt-controller: identifies the node as an interrupt controller
>> +- #interrupt-cells: specifies the number of cells needed to encode an interrupt
>> + source, should be 2.
>> +- actions,sirq-shared-reg: Applicable for S500 and S700 where SIRQ register
>> + details are maintained at same offset/register.
>> +- actions,sirq-reg-offset: register offset for SIRQ interrupts. When registers are
>> + shared, all the three offsets will be same (S500 and S700).
>
> These properties should be implied by the compatible string.
Agreed for sirq-shared-reg.
But for s900 sirq-reg-offset, the register offset will have different values.
So this shall not be removed.
>
>> +- actions,ext-irq-range: Identifies external irq number range in different SoCs.
>
> Why is this needed? It appears to always be the same.
Yes, I agree for all the existing Owl SoC's this remains same.
In the previous version we defined this as constant in the code. But based on Marc's
feedback I understood that this value should come from Device Tree instead on hard
coding in the code.
>
>> +
>> +Example for S900:
>> +
>> +sirq: interrupt-controller@e01b0000 {
>> + compatible = "actions,owl-sirq";
>> + reg = <0x0 0xe01b0000 0x0 0x1000>;
>> + interrupt-controller;
>> + #interrupt-cells = <3>;
>> + actions,sirq-offset = <0x200 0x528 0x52c>;
>> + actions,ext-irq-range = <13 15>;
>> +};
>> +
>> +Example for S700:
>
> Examples are examples, not an enumeration of all possible dts entries.
> So 1 should be sufficient.
Sure, I will maintain only s700 here.
>
>> +
>> +sirq: interrupt-controller@e01b0000 {
>> + compatible = "actions,owl-sirq";
>> + reg = <0x0 0xe01b0000 0x0 0x1000>;
>> + interrupt-controller;
>> + #interrupt-cells = <3>;
>> + actions,sirq-shared-reg;
>> + actions,sirq-reg-offset = <0x200 0x200 0x200>;
>> + actions,ext-irq-range = <13 15>;
>> +};
>> +
>> +Example for S500:
>> +
>> +sirq: interrupt-controller@b01b0000 {
>> + compatible = "actions,owl-sirq";
>> + reg = <0x0 0xb01b0000 0x0 0x1000>;
>> + interrupt-controller;
>> + #interrupt-cells = <3>;
>> + actions,sirq-shared-reg;
>> + actions,sirq-offset = <0x200 0x200 0x200>;
>> + actions,ext-irq-range = <13 15>;
>> +};
>> --
>> 2.17.2
>>
>
--
Thanks,
Parthiban N
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-22 Fax: (+49)-8142-66989-80 Email: pn@denx.de
next prev parent reply other threads:[~2018-12-09 19:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 10:03 [PATCH v3 0/4] Add Actions Semi Owl family sirq support Parthiban Nallathambi
2018-11-26 10:03 ` [PATCH v3 1/4] dt-bindings: interrupt-controller: Actions external interrupt controller Parthiban Nallathambi
2018-12-07 23:29 ` Rob Herring
2018-12-09 19:26 ` Parthiban Nallathambi [this message]
2018-11-26 10:03 ` [PATCH v3 2/4] drivers/irqchip: Add Actions external interrupts support Parthiban Nallathambi
2018-12-07 18:39 ` Marc Zyngier
2018-11-26 10:03 ` [PATCH v3 3/4] arm64: dts: actions: Add sirq node for Actions Semi S700 Parthiban Nallathambi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49bb60b8-a51b-a4e8-da29-52f0a951c37b@denx.de \
--to=pn@denx.de \
--cc=afaerber@suse.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=edgar.righi@lsitec.org.br \
--cc=guilherme.simoes@lsitec.org.br \
--cc=jason@lakedaemon.net \
--cc=laisa.costa@lsitec.org.br \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@cubietech.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mkzuffo@lsi.usp.br \
--cc=mp-cs@actions-semi.com \
--cc=robh@kernel.org \
--cc=sravanhome@gmail.com \
--cc=tglx@linutronix.de \
--cc=thomas.liau@actions-semi.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).